Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2693843002: Don't ignore "none" in underlying image lists for animations (Closed)

Created:
3 years, 10 months ago by alancutter (OOO until 2018)
Modified:
3 years, 10 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't ignore "none" in underlying image lists for animations This patch ensures "none" in the computed value of background-image and -webkit-mask-image are handled by animation code. Without this values like "url(x), none" behave like "url(x)". This issue is currently unreachable without refactoring CSS Transitions onto using CSSInterpolationTypes (https://codereview.chromium.org/2680923005). The relevant test case is: animations/interpolation/background-image-interpolation.html BUG=681424 Review-Url: https://codereview.chromium.org/2693843002 Cr-Commit-Position: refs/heads/master@{#451215} Committed: https://chromium.googlesource.com/chromium/src/+/cbd434ef8e9ef91ca5cfd146b937b3c76a3b0f2c

Patch Set 1 #

Patch Set 2 : Remove dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/ImageListPropertyFunctions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
alancutter (OOO until 2018)
3 years, 10 months ago (2017-02-16 02:52:58 UTC) #3
Eric Willigers
On 2017/02/16 02:52:58, alancutter wrote: Does https://codereview.chromium.org/2680923005 need a test case, or does the existing ...
3 years, 10 months ago (2017-02-16 04:58:37 UTC) #6
alancutter (OOO until 2018)
On 2017/02/16 at 04:58:37, ericwilligers wrote: > On 2017/02/16 02:52:58, alancutter wrote: > > Does ...
3 years, 10 months ago (2017-02-16 05:00:46 UTC) #7
Eric Willigers
lgtm
3 years, 10 months ago (2017-02-16 07:00:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693843002/20001
3 years, 10 months ago (2017-02-17 00:07:36 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 04:42:45 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cbd434ef8e9ef91ca5cfd146b937...

Powered by Google App Engine
This is Rietveld 408576698