Don't offset chrome:// page security bubbles.

Don't offset chrome:// page security bubbles.

It breaks the alignment logic under Harmony, and makes the alignment
inconsistent with regular bubbles under non-Harmony.

Note under non-Harmony, the Chrome icon in the bubble will no longer be
directly below the Chrome icon in the Omnibox. This is intentional.

Under Harmony, the icon in the bubble is going away.

BUG=691445
Review-Url: https://codereview.chromium.org/2693833002
Cr-Commit-Position: refs/heads/master@{#452707}
Committed: https://chromium.googlesource.com/chromium/src/+/28ad54cb961a743161398564f4f1f97ded3b2350

[Peter Kasting, 2017-02-23 23:49:20]

pkasting@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2017-02-23 23:49:20]

LGTM.

Based on your screenshots, I consider landing this better than what we have
without it, even if the icons are still present in both places and not
vertically aligned.  (IMO, they don't need to be vertically aligned at all, but
it sounds like we don't need to debate that since one will be going away.)

[tapted, 2017-02-23 23:55:32]

Description was changed from

==========
Don't offset chrome:// page security bubbles.

It breaks the alignment logic under Harmony, and makes the alignment
inconsistent with regular bubbles under non-Harmony.

BUG=691445
==========

to

==========
Don't offset chrome:// page security bubbles.

It breaks the alignment logic under Harmony, and makes the alignment
inconsistent with regular bubbles under non-Harmony.

Note under non-Harmony, the Chrome icon in the bubble will no longer be
directly below the Chrome icon in the Omnibox. This is intentional.

Under Harmony, the icon in the bubble is going away.

BUG=691445
==========

[tapted, 2017-02-23 23:57:23]

On 2017/02/23 23:49:20, Peter Kasting wrote:
> LGTM.
> 
> Based on your screenshots, I consider landing this better than what we have
> without it, even if the icons are still present in both places and not
> vertically aligned.  (IMO, they don't need to be vertically aligned at all,
but
> it sounds like we don't need to debate that since one will be going away.)

OK! Sounds good. I've updated the CL description with some extra paragraphs:

  Note under non-Harmony, the Chrome icon in the bubble will no longer be
  directly below the Chrome icon in the Omnibox. This is intentional.

  Under Harmony, the icon in the bubble is going away.

Hopefully if someone bisects down to this they will see the "this is
intentional" bit :)

[tapted, 2017-02-24 00:05:12]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-02-24 00:05:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 01:24:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487894712633900, "parent_rev":
"c64e1a693b3207b89733909793721b9af2ca5cd2", "commit_rev":
"28ad54cb961a743161398564f4f1f97ded3b2350"}

[commit-bot: I haz the power, 2017-02-24 01:25:31]

Description was changed from

==========
Don't offset chrome:// page security bubbles.

It breaks the alignment logic under Harmony, and makes the alignment
inconsistent with regular bubbles under non-Harmony.

Note under non-Harmony, the Chrome icon in the bubble will no longer be
directly below the Chrome icon in the Omnibox. This is intentional.

Under Harmony, the icon in the bubble is going away.

BUG=691445
==========

to

==========
Don't offset chrome:// page security bubbles.

It breaks the alignment logic under Harmony, and makes the alignment
inconsistent with regular bubbles under non-Harmony.

Note under non-Harmony, the Chrome icon in the bubble will no longer be
directly below the Chrome icon in the Omnibox. This is intentional.

Under Harmony, the icon in the bubble is going away.

BUG=691445

Review-Url: https://codereview.chromium.org/2693833002
Cr-Commit-Position: refs/heads/master@{#452707}
Committed:
https://chromium.googlesource.com/chromium/src/+/28ad54cb961a743161398564f4f1...
==========

[commit-bot: I haz the power, 2017-02-24 01:25:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/28ad54cb961a743161398564f4f1...