Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4319)

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Issue 2693833002: Don't offset chrome:// page security bubbles. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
index acc6392068a334f3b4e33ce7c3bb060db7d0ca7a..dee41bd0870ff7036f442d593dbfee1efb07a803 100644
--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
@@ -46,7 +46,6 @@
#include "ui/gfx/image/image.h"
#include "ui/resources/grit/ui_resources.h"
#include "ui/views/border.h"
-#include "ui/views/bubble/bubble_frame_view.h"
#include "ui/views/controls/button/image_button.h"
#include "ui/views/controls/button/md_text_button.h"
#include "ui/views/controls/image_view.h"
@@ -170,8 +169,6 @@ class InternalPageInfoPopupView : public views::BubbleDialogDelegateView {
~InternalPageInfoPopupView() override;
// views::BubbleDialogDelegateView:
- views::NonClientFrameView* CreateNonClientFrameView(
- views::Widget* widget) override;
void OnWidgetDestroying(views::Widget* widget) override;
int GetDialogButtons() const override;
@@ -326,16 +323,6 @@ InternalPageInfoPopupView::InternalPageInfoPopupView(
InternalPageInfoPopupView::~InternalPageInfoPopupView() {
}
-views::NonClientFrameView* InternalPageInfoPopupView::CreateNonClientFrameView(
- views::Widget* widget) {
- views::BubbleFrameView* frame = static_cast<views::BubbleFrameView*>(
- BubbleDialogDelegateView::CreateNonClientFrameView(widget));
- // Padding around icon + half of icon width.
- frame->bubble_border()->set_arrow_offset(
- kSpacing + 8 + frame->bubble_border()->GetBorderThickness());
- return frame;
-}
-
void InternalPageInfoPopupView::OnWidgetDestroying(views::Widget* widget) {
g_shown_popup_type = WebsiteSettingsPopupView::POPUP_NONE;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698