Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2693793003: Rename CRIWVWebViewConfiguration to CWVWebViewConfiguration (Closed)

Created:
3 years, 10 months ago by michaeldo
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename CRIWVWebViewConfiguration to CWVWebViewConfiguration BUG=690807 Review-Url: https://codereview.chromium.org/2693793003 Cr-Commit-Position: refs/heads/master@{#450403} Committed: https://chromium.googlesource.com/chromium/src/+/e3e53743dde9d4f707e7423e3b2b7fffd26ab09b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -79 lines) Patch
M ios/web_view/internal/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/internal/criwv.mm View 2 chunks +3 lines, -3 lines 0 comments Download
D ios/web_view/internal/criwv_web_view_configuration.mm View 1 chunk +0 lines, -41 lines 0 comments Download
M ios/web_view/internal/cwv_web_view.mm View 3 chunks +3 lines, -3 lines 0 comments Download
A + ios/web_view/internal/cwv_web_view_configuration.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web_view/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D ios/web_view/public/criwv_web_view_configuration.h View 1 chunk +0 lines, -21 lines 0 comments Download
M ios/web_view/public/cwv_web_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + ios/web_view/public/cwv_web_view_configuration.h View 2 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 2697453007 Patch 1

Dependent Patchsets:

Issue 2691883003 Patch 1

Messages

Total messages: 13 (7 generated)
michaeldo
3 years, 10 months ago (2017-02-14 00:23:16 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 10 months ago (2017-02-14 01:24:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693793003/1
3 years, 10 months ago (2017-02-14 06:14:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/382099) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, ...
3 years, 10 months ago (2017-02-14 12:15:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693793003/1
3 years, 10 months ago (2017-02-14 16:49:16 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 18:20:31 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e3e53743dde9d4f707e7423e3b2b...

Powered by Google App Engine
This is Rietveld 408576698