Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2693543002: Remove logo from Physical Web omnibox suggestions (Closed)

Created:
3 years, 10 months ago by mattreynolds
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Remove logo from Physical Web omnibox suggestions Previously, Physical Web suggestions displayed a logo image at the end of the suggestion row. With this change, the logo is removed. Single-URL Physical Web suggestions will display the append-into-edit arrow button. Grouped suggestions will display no icon. BUG=686870 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2674543002 Cr-Commit-Position: refs/heads/master@{#448331} (cherry picked from commit eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec) Review-Url: https://codereview.chromium.org/2693543002 Cr-Commit-Position: refs/branch-heads/2987@{#451} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/93ce0f4d2334a313c678968992bad1e174f7859b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -91 lines) Patch
M ios/chrome/app/main_controller.mm View 3 chunks +0 lines, -17 lines 0 comments Download
D ios/chrome/app/theme/default_100_percent/omnibox/physical_web_highlighted_ios.png View Binary file 0 comments Download
D ios/chrome/app/theme/default_100_percent/omnibox/physical_web_ios.png View Binary file 0 comments Download
D ios/chrome/app/theme/default_200_percent/omnibox/physical_web_highlighted_ios.png View Binary file 0 comments Download
D ios/chrome/app/theme/default_200_percent/omnibox/physical_web_ios.png View Binary file 0 comments Download
D ios/chrome/app/theme/default_300_percent/omnibox/physical_web_highlighted_ios.png View Binary file 0 comments Download
D ios/chrome/app/theme/default_300_percent/omnibox/physical_web_ios.png View Binary file 0 comments Download
M ios/chrome/app/theme/ios_theme_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/commands/ios_command_ids.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm View 4 chunks +0 lines, -17 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm View 5 chunks +6 lines, -30 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_navigation_controller.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_navigation_controller.mm View 3 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693543002/1
3 years, 10 months ago (2017-02-10 20:48:22 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-10 20:48:24 UTC) #4
rohitrao (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-10 20:49:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693543002/1
3 years, 10 months ago (2017-02-10 20:50:11 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-10 20:50:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693543002/1
3 years, 10 months ago (2017-02-10 21:04:22 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 21:07:17 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/93ce0f4d2334a313c678968992ba...

Powered by Google App Engine
This is Rietveld 408576698