Remove logo from Physical Web omnibox suggestions

Remove logo from Physical Web omnibox suggestions

Previously, Physical Web suggestions displayed a logo image at the end of
the suggestion row. With this change, the logo is removed. Single-URL
Physical Web suggestions will display the append-into-edit arrow button.
Grouped suggestions will display no icon.

BUG=686870
Review-Url: https://codereview.chromium.org/2674543002
Cr-Commit-Position: refs/heads/master@{#448331}
Committed: https://chromium.googlesource.com/chromium/src/+/eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec

[mattreynolds, 2017-02-02 00:51:50]

mattreynolds@chromium.org changed reviewers:
+ rohitrao@chromium.org

[mattreynolds, 2017-02-02 00:51:50]

Hi Rohit, PTAL

This CL removes the logo button from the suggestion view. I left the image
assets because we're hoping we can convince UX to bring them back for M58.

[rohitrao (ping after 24h), 2017-02-03 21:11:10]

https://codereview.chromium.org/2674543002/diff/1/ios/chrome/browser/ui/omnib...
File ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm (left):

https://codereview.chromium.org/2674543002/diff/1/ios/chrome/browser/ui/omnib...
ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm:170: UIImage*
physicalWebImage = NativeImage(IDR_IOS_OMNIBOX_PHYSICAL_WEB);
Are these two images used anywhere else?  Can they be removed from the codebase?

https://codereview.chromium.org/2674543002/diff/1/ios/chrome/browser/ui/omnib...
File ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm
(left):

https://codereview.chromium.org/2674543002/diff/1/ios/chrome/browser/ui/omnib...
ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm:658:
[GenericChromeCommand alloc] initWithTag:IDC_SHOW_PHYSICAL_WEB_SETTINGS]);
Is this the only place that we send this command?  Can we remove the supporting
code from MainController and remove the command id?

[mattreynolds, 2017-02-03 22:41:45]

https://codereview.chromium.org/2674543002/diff/1/ios/chrome/browser/ui/omnib...
File ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm (left):

https://codereview.chromium.org/2674543002/diff/1/ios/chrome/browser/ui/omnib...
ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm:170: UIImage*
physicalWebImage = NativeImage(IDR_IOS_OMNIBOX_PHYSICAL_WEB);
On 2017/02/03 21:11:10, rohitrao wrote:
> Are these two images used anywhere else?  Can they be removed from the
codebase?

They're unused, I'll remove them.

https://codereview.chromium.org/2674543002/diff/1/ios/chrome/browser/ui/omnib...
File ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm
(left):

https://codereview.chromium.org/2674543002/diff/1/ios/chrome/browser/ui/omnib...
ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm:658:
[GenericChromeCommand alloc] initWithTag:IDC_SHOW_PHYSICAL_WEB_SETTINGS]);
On 2017/02/03 21:11:10, rohitrao wrote:
> Is this the only place that we send this command?  Can we remove the
supporting
> code from MainController and remove the command id?

Done.

[rohitrao (ping after 24h), 2017-02-06 14:18:41]

lgtm

[mattreynolds, 2017-02-06 18:39:33]

The CQ bit was checked by mattreynolds@chromium.org

[commit-bot: I haz the power, 2017-02-06 18:39:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 19:04:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486406373501700,
"parent_rev": "b8d63f435e6c869164a0ec63eec5be867d2b7157", "commit_rev":
"eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec"}

[commit-bot: I haz the power, 2017-02-06 19:04:36]

Description was changed from

==========
Remove logo from Physical Web omnibox suggestions

Previously, Physical Web suggestions displayed a logo image at the end of
the suggestion row. With this change, the logo is removed. Single-URL
Physical Web suggestions will display the append-into-edit arrow button.
Grouped suggestions will display no icon.

BUG=686870
==========

to

==========
Remove logo from Physical Web omnibox suggestions

Previously, Physical Web suggestions displayed a logo image at the end of
the suggestion row. With this change, the logo is removed. Single-URL
Physical Web suggestions will display the append-into-edit arrow button.
Grouped suggestions will display no icon.

BUG=686870

Review-Url: https://codereview.chromium.org/2674543002
Cr-Commit-Position: refs/heads/master@{#448331}
Committed:
https://chromium.googlesource.com/chromium/src/+/eb78c99e38bdd1c36d8e1b0b4239...
==========

[commit-bot: I haz the power, 2017-02-06 19:04:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eb78c99e38bdd1c36d8e1b0b4239...