Ensure ChromeVox defaults to ChromeVox Next on upgrade

Ensure ChromeVox defaults to ChromeVox Next on upgrade

In an upgrade scenario, local storage persists. As a result, key/values for 'useNext' retain their defaults (as set by prefs.js).

In m56, we want useNext to default to true.

Ensure this by adding a new pref, 'useClassic', that is ensured to be a new key on upgrade.

BUG=690939
TEST=have a profile with the previous key/value local storage set. Apply this patch, and ensure newly built Chrome *defaults* to Next on launch. Use this build in Learn Mode and ensure key mappings respect mode (e.g. classic keys described when in classic mode).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2693463002
Cr-Commit-Position: refs/heads/master@{#449670}
Committed: https://chromium.googlesource.com/chromium/src/+/2c6de2bebee569ee216b4b6688625147601c2a23

[David Tseng, 2017-02-10 15:32:21]

Description was changed from

==========
Ensure ChromeVox defaluts to ChromeVox Next

In an upgrade scenario, local storage persists. As a result, key/values for
'useNext' retain their defaults (as set by prefs.js).

In m56, we want useNext to default to true.

Ensure this by adding a new pref, 'useClassic', that is ensured to be a new key
on upgrade.

BUG=
==========

to

==========
Ensure ChromeVox defaluts to ChromeVox Next

In an upgrade scenario, local storage persists. As a result, key/values for
'useNext' retain their defaults (as set by prefs.js).

In m56, we want useNext to default to true.

Ensure this by adding a new pref, 'useClassic', that is ensured to be a new key
on upgrade.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-02-10 15:35:49]

Description was changed from

==========
Ensure ChromeVox defaluts to ChromeVox Next

In an upgrade scenario, local storage persists. As a result, key/values for
'useNext' retain their defaults (as set by prefs.js).

In m56, we want useNext to default to true.

Ensure this by adding a new pref, 'useClassic', that is ensured to be a new key
on upgrade.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Ensure ChromeVox defaults to ChromeVox Next on upgrade

In an upgrade scenario, local storage persists. As a result, key/values for
'useNext' retain their defaults (as set by prefs.js).

In m56, we want useNext to default to true.

Ensure this by adding a new pref, 'useClassic', that is ensured to be a new key
on upgrade.

BUG=690939
TEST=have a profile with the previous key/value local storage set. Apply this
patch, and ensure newly built Chrome *defaults* to Next on launch. Use this
build in Learn Mode and ensure key mappings respect mode (e.g. classic keys
described when in classic mode).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-02-10 15:35:49]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-02-10 15:38:26]

lgtm

[David Tseng, 2017-02-10 15:38:47]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 15:39:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 17:17:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 17:17:22]

Dry run: This issue passed the CQ dry run.

[David Tseng, 2017-02-10 17:23:35]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2017-02-10 17:23:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 17:28:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 17:28:35]

Failed to apply patch for
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:92
  error: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:
patch does not apply

Patch:      
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
diff --git
a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
index
ac9318b473d4ba26b11bf0699615829630331a45..d501c206c542a46b557e1d8212e5980c8d2c6a75
100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
@@ -92,7 +92,7 @@ Panel.init = function() {
    * @type {boolean}
    * @private
    */
-  this.menusEnabled_ = localStorage['useNext'] == 'true';
+  this.menusEnabled_ = localStorage['useClassic'] == 'false';
 
   /**
    * True if we're currently in incremental search mode.

[David Tseng, 2017-02-10 17:42:38]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2017-02-10 17:42:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2693463002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-10 17:43:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 18:46:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486748558420060,
"parent_rev": "674565161b44e1505e220f1864803647698d9a8e", "commit_rev":
"2c6de2bebee569ee216b4b6688625147601c2a23"}

[commit-bot: I haz the power, 2017-02-10 18:47:34]

Description was changed from

==========
Ensure ChromeVox defaults to ChromeVox Next on upgrade

In an upgrade scenario, local storage persists. As a result, key/values for
'useNext' retain their defaults (as set by prefs.js).

In m56, we want useNext to default to true.

Ensure this by adding a new pref, 'useClassic', that is ensured to be a new key
on upgrade.

BUG=690939
TEST=have a profile with the previous key/value local storage set. Apply this
patch, and ensure newly built Chrome *defaults* to Next on launch. Use this
build in Learn Mode and ensure key mappings respect mode (e.g. classic keys
described when in classic mode).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Ensure ChromeVox defaults to ChromeVox Next on upgrade

In an upgrade scenario, local storage persists. As a result, key/values for
'useNext' retain their defaults (as set by prefs.js).

In m56, we want useNext to default to true.

Ensure this by adding a new pref, 'useClassic', that is ensured to be a new key
on upgrade.

BUG=690939
TEST=have a profile with the previous key/value local storage set. Apply this
patch, and ensure newly built Chrome *defaults* to Next on launch. Use this
build in Learn Mode and ensure key mappings respect mode (e.g. classic keys
described when in classic mode).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2693463002
Cr-Commit-Position: refs/heads/master@{#449670}
Committed:
https://chromium.googlesource.com/chromium/src/+/2c6de2bebee569ee216b4b668862...
==========

[commit-bot: I haz the power, 2017-02-10 18:47:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2c6de2bebee569ee216b4b668862...