chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js - Issue 2693463002: Ensure ChromeVox defaults to ChromeVox Next on upgrade

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 2693463002: Ensure ChromeVox defaults to ChromeVox Next on upgrade (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

index 9003210b1e7b9b58a188961e7f90369f529359ff..9eb004733419fe7e04c438bdf3ec588942b4e844 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

@@ -175,7 +175,7 @@ Background = function() {

}.bind(this));

// Record a metric with the mode we're in on startup.

- var useNext = localStorage['useNext'] !== 'false';

+ var useNext = localStorage['useClassic'] != 'true';

chrome.metricsPrivate.recordValue(

{ metricName: 'Accessibility.CrosChromeVoxNext',

type: chrome.metricsPrivate.MetricTypeType.HISTOGRAM_LINEAR,

@@ -232,7 +232,7 @@ Background.prototype = {

* @override

getMode: function() {

- var useNext = localStorage['useNext'] !== 'false';

+ var useNext = localStorage['useClassic'] !== 'true';

var target;

if (!this.getCurrentRange()) {

@@ -358,7 +358,7 @@ Background.prototype = {

if (opt_setValue !== undefined)

useNext = opt_setValue;

else

- useNext = localStorage['useNext'] !== 'true';

+ useNext = localStorage['useClassic'] == 'true';

if (useNext) {

chrome.metricsPrivate.recordUserAction(

@@ -368,7 +368,7 @@ Background.prototype = {

'Accessibility.ChromeVox.ToggleNextOff');

}

- localStorage['useNext'] = useNext;

+ localStorage['useClassic'] = !useNext;

if (useNext)

this.setCurrentRangeToFocus_();

else