Migrate WTF::HashMap::add() to ::insert() [final]

Migrate WTF::HashMap::add() to ::insert() [final]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL completes the migration process from add() to insert() and
removes the add() methods from HashMap.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2693433002
Cr-Commit-Position: refs/heads/master@{#449715}
Committed: https://chromium.googlesource.com/chromium/src/+/9245a032ae8afde088def22c747bdb78d423a0ff

[pilgrim_google, 2017-02-10 14:50:50]

Description was changed from

==========
Migrate WTF::HashMap::add() to ::insert() [final]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL completes the migration process from add() to insert() and
removes the add() methods from HashMap.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::HashMap::add() to ::insert() [final]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL completes the migration process from add() to insert() and
removes the add() methods from HashMap.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pilgrim_google, 2017-02-10 14:51:04]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[pilgrim_google, 2017-02-10 14:51:19]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, sky@chromium.org,
yutak@chromium.org

[commit-bot: I haz the power, 2017-02-10 14:51:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 15:24:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 15:24:43]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[pilgrim_google, 2017-02-10 15:32:50]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 15:33:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 16:26:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 16:26:03]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[pilgrim_google, 2017-02-10 16:35:06]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 16:35:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-10 16:52:17]

LGTM

[pilgrim_google, 2017-02-10 16:58:41]

The CQ bit was unchecked by pilgrim@chromium.org

[pilgrim_google, 2017-02-10 16:58:42]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2017-02-10 16:58:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 17:09:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 17:09:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pilgrim_google, 2017-02-10 17:09:47]

Description was changed from

==========
Migrate WTF::HashMap::add() to ::insert() [final]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL completes the migration process from add() to insert() and
removes the add() methods from HashMap.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Migrate WTF::HashMap::add() to ::insert() [final]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL completes the migration process from add() to insert() and
removes the add() methods from HashMap.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org
==========

[pilgrim_google, 2017-02-10 17:09:49]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2017-02-10 17:10:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-02-10 19:52:54]

LGTM

[commit-bot: I haz the power, 2017-02-10 20:16:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486746589940130,
"parent_rev": "2fe7948da152f6d65725173f0ec1fa916e3a016c", "commit_rev":
"9245a032ae8afde088def22c747bdb78d423a0ff"}

[commit-bot: I haz the power, 2017-02-10 20:16:56]

Description was changed from

==========
Migrate WTF::HashMap::add() to ::insert() [final]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL completes the migration process from add() to insert() and
removes the add() methods from HashMap.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org
==========

to

==========
Migrate WTF::HashMap::add() to ::insert() [final]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL completes the migration process from add() to insert() and
removes the add() methods from HashMap.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2693433002
Cr-Commit-Position: refs/heads/master@{#449715}
Committed:
https://chromium.googlesource.com/chromium/src/+/9245a032ae8afde088def22c747b...
==========

[commit-bot: I haz the power, 2017-02-10 20:16:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9245a032ae8afde088def22c747b...