third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp - Issue 2693433002: Migrate WTF::HashMap::add() to ::insert() [final]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp

Issue 2693433002: Migrate WTF::HashMap::add() to ::insert() [final] (Closed)

Patch Set: more platform-specific references Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp b/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp

index a6e589d4f3328ed6f8153b9c765aba9168a9eb4c..9b325db99fc9da005c464cef12cf40b4a9a0feca 100644

--- a/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp

+++ b/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp

@@ -223,9 +223,9 @@ void ImageDecodingStore::insertCacheInternal(std::unique_ptr<T> cacheEntry,

typename U::KeyType key = cacheEntry->cacheKey();

typename V::AddResult result =

- identifierMap->add(cacheEntry->generator(), typename V::MappedType());

+ identifierMap->insert(cacheEntry->generator(), typename V::MappedType());

result.storedValue->value.insert(key);

- cacheMap->add(key, std::move(cacheEntry));

+ cacheMap->insert(key, std::move(cacheEntry));

TRACE_COUNTER1(TRACE_DISABLED_BY_DEFAULT("blink.image_decoding"),

"ImageDecodingStoreHeapMemoryUsageBytes",