Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2693383003: [DevTools] Refactor CSS live locations. (Closed)

Created:
3 years, 10 months ago by dgozman
Modified:
3 years, 10 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Refactor CSS live locations. - removed CSSLocation._header as it could be gone; turned it to nullable getter. - only listen to StyleSheet{Added,Removed} events once, not from every live location. - removed extra layers from CSSWorkspaceBinding. BUG=none Review-Url: https://codereview.chromium.org/2693383003 Cr-Commit-Position: refs/heads/master@{#451426} Committed: https://chromium.googlesource.com/chromium/src/+/6e3c903599a2816c4a7c68eccd4e95b35e1f9893

Patch Set 1 #

Total comments: 6

Patch Set 2 : review comments addressed #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -137 lines) Patch
M third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js View 1 9 chunks +76 lines, -127 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
dgozman
Could you please take a look?
3 years, 10 months ago (2017-02-16 01:29:03 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2693383003/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js File third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js (right): https://codereview.chromium.org/2693383003/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js#newcode171 third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:171: this._unboundLocations.set(location._rawLocation.url, location); location.update() should be called here https://codereview.chromium.org/2693383003/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js#newcode206 ...
3 years, 10 months ago (2017-02-16 02:40:03 UTC) #3
dgozman
https://codereview.chromium.org/2693383003/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js File third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js (right): https://codereview.chromium.org/2693383003/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js#newcode171 third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:171: this._unboundLocations.set(location._rawLocation.url, location); On 2017/02/16 02:40:03, lushnikov wrote: > location.update() ...
3 years, 10 months ago (2017-02-16 18:25:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693383003/40001
3 years, 10 months ago (2017-02-17 20:01:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/367421) win_clang on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 10 months ago (2017-02-17 20:27:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693383003/40001
3 years, 10 months ago (2017-02-17 20:57:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/121846)
3 years, 10 months ago (2017-02-17 22:40:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693383003/40001
3 years, 10 months ago (2017-02-17 22:46:13 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-17 23:02:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693383003/40001
3 years, 10 months ago (2017-02-18 01:03:26 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-18 03:05:44 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693383003/40001
3 years, 10 months ago (2017-02-18 04:54:37 UTC) #23
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 06:22:41 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6e3c903599a2816c4a7c68eccd4e...

Powered by Google App Engine
This is Rietveld 408576698