third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js - Issue 2693383003: [DevTools] Refactor CSS live locations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js

Issue 2693383003: [DevTools] Refactor CSS live locations. (Closed)

Patch Set: rebased Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js b/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js

index 49cb560acdc6cfcf0a820d99581a6e6968d0192a..7b550638cd7a36afc55b32b91db7dc79f90c9133 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js

@@ -63,13 +63,14 @@ Bindings.StylesSourceMapping = class {

* @return {?Workspace.UILocation}

rawLocationToUILocation(rawLocation) {

- var uiSourceCode =

- Bindings.NetworkProject.uiSourceCodeForStyleURL(this._workspace, rawLocation.url, rawLocation.header());

+ var header = rawLocation.header();

+ if (!header)

+ return null;

+ var uiSourceCode = Bindings.NetworkProject.uiSourceCodeForStyleURL(this._workspace, rawLocation.url, header);

if (!uiSourceCode)

return null;

var lineNumber = rawLocation.lineNumber;

var columnNumber = rawLocation.columnNumber;

- var header = this._cssModel.styleSheetHeaderForId(rawLocation.styleSheetId);

if (header && header.isInline && header.hasSourceURL) {

lineNumber -= header.lineNumberInSource(0);

columnNumber -= header.columnNumberInSource(lineNumber, 0);