Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2693373004: Use Smart Lock preference instead of Chrome Password manager preference. (Closed)

Created:
3 years, 10 months ago by melandory
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Use Smart Lock preference instead of Chrome Password manager preference. After this CL the ability to change Chrome Password manager preference will be not exposed anymore. The two preferences have same values, because they were reconciled previously. Smart Lock preference: credentials_enable_service Chrome Password Manager preference: profile.password_manager_enabled BUG=517087, 658683 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1273053002 Cr-Commit-Position: refs/heads/master@{#450326} (cherry picked from commit 3f2af32fde9d68961f9fd41c824441627acd6be8) Review-Url: https://codereview.chromium.org/2693373004 . Cr-Commit-Position: refs/branch-heads/2987@{#540} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/7ca30d63ded3525cdab87cb205161ba3751b75ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M chrome/browser/android/preferences/pref_service_bridge.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/preference/preference_apitest.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/settings/passwords_and_forms_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_generation_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
melandory
3 years, 10 months ago (2017-02-16 09:28:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7ca30d63ded3525cdab87cb205161ba3751b75ab.

Powered by Google App Engine
This is Rietveld 408576698