Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2693373002:
[MD Settings] Add title to show/hide password button. (Closed)
|
Created:
3 years, 10 months ago by hcarmona Modified:
3 years, 10 months ago Reviewers:
dschuyler CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, michaelpg+watch-md-settings_chromium.org, dbeam+watch-closure_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, gcasto+watchlist_chromium.org, jlklein+watch-closure_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD Settings] Add title to show/hide password button.
BUG=690362
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2693373002
Cr-Commit-Position: refs/heads/master@{#450987}
Committed: https://chromium.googlesource.com/chromium/src/+/52c6fa8ea1623e667d43661526707cb4da6feed2
Patch Set 1 #
Total comments: 8
Patch Set 2 : feedback #
Messages
Total messages: 25 (17 generated)
Description was changed from ========== [MD Settings] Add title to show/hide password button. BUG=690362 ========== to ========== [MD Settings] Add title to show/hide password button. BUG=690362 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hcarmona@chromium.org changed reviewers: + dschuyler@chromium.org
PTAL
https://codereview.chromium.org/2693373002/diff/1/chrome/app/settings_strings... File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2693373002/diff/1/chrome/app/settings_strings... chrome/app/settings_strings.grdp:417: <message name="IDS_SETTINGS_PASSWORD_SHOW" desc="Label for a tool tip on a button that reveals the saved password."> "Label for" seems redundant with "a tool tip" consider s/Label for a/A/ Same for the message below. https://codereview.chromium.org/2693373002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html (right): https://codereview.chromium.org/2693373002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:43: title="[[showPasswordTitle_(password)]]"> We now have $i18nPolymer, yay! Consider changing this to [[showPasswordTitle_(password, '$i18nPolymer{hidePassword}', '$i18nPolymer{showPassword}')]] https://codereview.chromium.org/2693373002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js (right): https://codereview.chromium.org/2693373002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js:16: behaviors: [I18nBehavior], With $i18nPolymer this behavior can be removed. https://codereview.chromium.org/2693373002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js:56: return password ? this.i18n('hidePassword') : this.i18n('showPassword'); With $i18nPolymer this could become: showPasswordTitle_: function(password, hide, show) { return password ? hide : show;
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Patchset #2 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2693373002/diff/1/chrome/app/settings_strings... File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2693373002/diff/1/chrome/app/settings_strings... chrome/app/settings_strings.grdp:417: <message name="IDS_SETTINGS_PASSWORD_SHOW" desc="Label for a tool tip on a button that reveals the saved password."> On 2017/02/15 20:12:15, dschuyler wrote: > "Label for" seems redundant with "a tool tip" consider > s/Label for a/A/ > > Same for the message below. Done. https://codereview.chromium.org/2693373002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html (right): https://codereview.chromium.org/2693373002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:43: title="[[showPasswordTitle_(password)]]"> On 2017/02/15 20:12:15, dschuyler wrote: > We now have $i18nPolymer, yay! Consider changing this to > > [[showPasswordTitle_(password, '$i18nPolymer{hidePassword}', > '$i18nPolymer{showPassword}')]] Done. https://codereview.chromium.org/2693373002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js (right): https://codereview.chromium.org/2693373002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js:16: behaviors: [I18nBehavior], On 2017/02/15 20:12:15, dschuyler wrote: > With $i18nPolymer this behavior can be removed. Done. https://codereview.chromium.org/2693373002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js:56: return password ? this.i18n('hidePassword') : this.i18n('showPassword'); On 2017/02/15 20:12:15, dschuyler wrote: > With $i18nPolymer this could become: > showPasswordTitle_: function(password, hide, show) { > return password ? hide : show; Sweet. Done.
lgtm
The CQ bit was unchecked by hcarmona@chromium.org
The CQ bit was checked by hcarmona@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by hcarmona@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487262451195750,
"parent_rev": "e099d37714f0b9f1bc4856115c85479bbb1f3e1c", "commit_rev":
"52c6fa8ea1623e667d43661526707cb4da6feed2"}
Message was sent while issue was closed.
Description was changed from ========== [MD Settings] Add title to show/hide password button. BUG=690362 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Settings] Add title to show/hide password button. BUG=690362 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2693373002 Cr-Commit-Position: refs/heads/master@{#450987} Committed: https://chromium.googlesource.com/chromium/src/+/52c6fa8ea1623e667d4366152670... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/52c6fa8ea1623e667d4366152670... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
