chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js - Issue 2693373002: [MD Settings] Add title to show/hide password button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js

Issue 2693373002: [MD Settings] Add title to show/hide password button. (Closed)

Patch Set: feedback Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js

index b2b55bb5d5b3d89e2d12164f3a948984c63fe412..bfa1e2d283934a8ab457b62192c836d1dac2ad9c 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js

@@ -46,6 +46,17 @@ Polymer({

/**

+ * Gets the title text for the show/hide icon.

+ * @param {string} password

+ * @param {string} hide The i18n text to use for 'Hide'

+ * @param {string} show The i18n text to use for 'Show'

+ * @private

+ */

+ showPasswordTitle_: function(password, hide, show) {

+ return password ? hide : show;

+ },

+ /**

* Gets the text of the password. Will use the value of |password| unless it

* cannot be shown, in which case it will be spaces.

* @param {!chrome.passwordsPrivate.PasswordUiEntry} item