clang tot bots: let mac/win asan bots use non-stale asan runtimes

clang tot bots: let mac/win asan bots use non-stale asan runtimes

Follow-up to https://codereview.chromium.org/2626293003/

BUG=

Review-Url: https://codereview.chromium.org/2693213002
Cr-Commit-Position: refs/heads/master@{#450547}
Committed: https://chromium.googlesource.com/chromium/src/+/a95e0192e7bd1f896eed55bad41cdc4ba9f46cb2

[Nico, 2017-02-14 23:04:31]

thakis@chromium.org changed reviewers:
+ hans@chromium.org

[Nico, 2017-02-14 23:04:31]

should unbreak
https://build.chromium.org/p/chromium.fyi/builders/ClangToTMacASan/builds/875...

We only noticed this by accident :-(

Maybe we could shell out only on the tot bots, where gn perf is less important
-- on the pinned bots we clobber the clang dir on each clang download, so it'd
be an insta-error there and we would've noticed there even while hardcoding.

Or we could do hard clobber builds of llvm on each build on the tot bots, that
would've caught it too.

[Nico, 2017-02-14 23:04:34]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 23:05:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hans, 2017-02-14 23:06:50]

lgtm

[Nico, 2017-02-14 23:07:08]

Another medium-term idea would be to have an explicit build step that
compares update.py --print-clang-version to the gn var and that depends on
update.py.

On Tue, Feb 14, 2017 at 6:04 PM, <thakis@chromium.org> wrote:

> Reviewers: hans
> CL: https://codereview.chromium.org/2693213002/
>
> Message:
> should unbreak
> https://build.chromium.org/p/chromium.fyi/builders/
> ClangToTMacASan/builds/8751/steps/compile/logs/stdio
>
> We only noticed this by accident :-(
>
> Maybe we could shell out only on the tot bots, where gn perf is less
> important
> -- on the pinned bots we clobber the clang dir on each clang download, so
> it'd
> be an insta-error there and we would've noticed there even while
> hardcoding.
>
> Or we could do hard clobber builds of llvm on each build on the tot bots,
> that
> would've caught it too.
>
> Description:
> clang tot bots: let mac/win asan bots use non-stale asan runtimes
>
> Follow-up to https://codereview.chromium.org/2626293003/
>
> BUG=
>
> Affected files (+6, -1 lines):
> M build/toolchain/toolchain.gni
>
>
> Index: build/toolchain/toolchain.gni
> diff --git a/build/toolchain/toolchain.gni b/build/toolchain/toolchain.gni
> index 48e3671a047828687bbf287b427578d9d7907f38..
> 5722c125d0073196a0476e37541ecf9f9493aa9e 100644
> --- a/build/toolchain/toolchain.gni
> +++ b/build/toolchain/toolchain.gni
> @@ -50,7 +50,12 @@ hermetic_xcode_path =
> declare_args() {
> if (is_clang) {
> # Clang compiler version. Clang files are placed at version-dependent
> paths.
> - clang_version = "4.0.0"
> + if (llvm_force_head_revision) {
> + clang_version = "5.0.0"
> + } else {
> + # TODO(thakis): Remove this branch the next time clang rolls.
> + clang_version = "4.0.0"
> + }
> }
> }
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2017-02-14 23:07:08]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2017-02-14 23:07:12]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-02-14 23:07:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 01:37:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487113632750200, "parent_rev":
"1820742c54f9c5ec33cdc8e334a8117090ac056f", "commit_rev":
"a95e0192e7bd1f896eed55bad41cdc4ba9f46cb2"}

[commit-bot: I haz the power, 2017-02-15 01:37:44]

Description was changed from

==========
clang tot bots: let mac/win asan bots use non-stale asan runtimes

Follow-up to https://codereview.chromium.org/2626293003/

BUG=
==========

to

==========
clang tot bots: let mac/win asan bots use non-stale asan runtimes

Follow-up to https://codereview.chromium.org/2626293003/

BUG=

Review-Url: https://codereview.chromium.org/2693213002
Cr-Commit-Position: refs/heads/master@{#450547}
Committed:
https://chromium.googlesource.com/chromium/src/+/a95e0192e7bd1f896eed55bad41c...
==========

[commit-bot: I haz the power, 2017-02-15 01:37:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a95e0192e7bd1f896eed55bad41c...