Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2626293003: Clang update script: trunk is now 5.0.0 (Closed)

Created:
3 years, 11 months ago by hans
Modified:
3 years, 10 months ago
Reviewers:
Reid Kleckner, Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clang update script: trunk is now 5.0.0 BUG=none Review-Url: https://codereview.chromium.org/2626293003 Cr-Commit-Position: refs/heads/master@{#443467} Committed: https://chromium.googlesource.com/chromium/src/+/451b04815e74a1da95930da2166489ffb0e5bde2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
hans
Please take a look. Feel free to cq if it's good; I'm heading out in ...
3 years, 11 months ago (2017-01-13 01:03:51 UTC) #2
Reid Kleckner
lgtm Thanks, I spotted this as well on the tot waterfall.
3 years, 11 months ago (2017-01-13 01:11:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626293003/1
3 years, 11 months ago (2017-01-13 01:12:01 UTC) #5
Nico
lgtm 2 (i would've put the link to https://codereview.chromium.org/2178483002 in the cl description, but doesn't ...
3 years, 11 months ago (2017-01-13 01:35:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/451b04815e74a1da95930da2166489ffb0e5bde2
3 years, 11 months ago (2017-01-13 02:18:54 UTC) #9
Nico
note for next time: we need to update https://cs.chromium.org/chromium/src/build/toolchain/toolchain.gni?type=cs&q=clang_version+package:%5Echromium$+file:%5C.gn&l=53 too. the asan tot bots have ...
3 years, 10 months ago (2017-02-14 22:58:53 UTC) #10
Nico
3 years, 10 months ago (2017-02-14 23:10:39 UTC) #11
Message was sent while issue was closed.
On 2017/02/14 22:58:53, Nico wrote:
> note for next time: we need to update
>
https://cs.chromium.org/chromium/src/build/toolchain/toolchain.gni?type=cs&q=...
> too. the asan tot bots have been silently using old asan libs due to us
missing
> this :-/

(https://codereview.chromium.org/2693213002/)

Powered by Google App Engine
This is Rietveld 408576698