Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2693193005: [Windows MSVC CFG] Turning on linker CFG for all. Removing CFG compile. (Closed)

Created:
3 years, 10 months ago by penny
Modified:
3 years, 10 months ago
CC:
caitkp+watch_chromium.org, chromium-reviews, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Windows MSVC CFG] Turning on linker CFG for all. Disabling CFG compile. This enables support for CFG that is already compiled into Microsoft system DLLs - in any of our processes. Also disabling compilation of CFG with MSVC compiler. Preparing for clang CFI instead. TEST=CFGSupportTests.MsIndirectFailure in sbox_integration_tests suite. BUG=584575 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng TBR=thestig or jochen (chrome\BUILD.gn) Review-Url: https://codereview.chromium.org/2693193005 Cr-Commit-Position: refs/heads/master@{#451116} Committed: https://chromium.googlesource.com/chromium/src/+/f160102d25fb949a3ed24478268b8835cc086477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -23 lines) Patch
M build/config/win/BUILD.gn View 2 chunks +9 lines, -11 lines 0 comments Download
M chrome/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome_elf/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/win/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/win/tests/integration_tests/cfi_unittest_exe.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
penny
Hello folks, Thanks for your help doing a small review. This CL moves the linker ...
3 years, 10 months ago (2017-02-15 00:53:02 UTC) #6
scottmg
lgtm
3 years, 10 months ago (2017-02-15 20:42:57 UTC) #12
Will Harris
I think this means we'll only use CFG on LINK.EXE from now on, and not ...
3 years, 10 months ago (2017-02-15 20:49:04 UTC) #13
penny
On 2017/02/15 20:49:04, Will Harris wrote: > I think this means we'll only use CFG ...
3 years, 10 months ago (2017-02-15 21:44:39 UTC) #14
Will Harris
Is removing compiler-time CFG from chrome_elf an acceptable security regression?
3 years, 10 months ago (2017-02-15 21:46:20 UTC) #15
penny
On 2017/02/15 21:46:20, Will Harris wrote: > Is removing compiler-time CFG from chrome_elf an acceptable ...
3 years, 10 months ago (2017-02-15 21:51:34 UTC) #16
penny
On 2017/02/15 21:51:34, penny wrote: > On 2017/02/15 21:46:20, Will Harris wrote: > > Is ...
3 years, 10 months ago (2017-02-15 21:52:50 UTC) #17
Will Harris
lgtm
3 years, 10 months ago (2017-02-15 21:53:28 UTC) #18
penny
On 2017/02/15 21:52:50, penny wrote: > On 2017/02/15 21:51:34, penny wrote: > > On 2017/02/15 ...
3 years, 10 months ago (2017-02-15 21:54:48 UTC) #19
penny
jochen, could I get you to review a tiny change to src\chrome\BUILD.gn please? thestig appears ...
3 years, 10 months ago (2017-02-15 22:02:27 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693193005/1
3 years, 10 months ago (2017-02-16 20:07:06 UTC) #25
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-16 20:08:34 UTC) #26
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 22:22:22 UTC) #29
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f160102d25fb949a3ed24478268b...

Powered by Google App Engine
This is Rietveld 408576698