Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1687)

Unified Diff: sandbox/win/tests/integration_tests/cfi_unittest_exe.cc

Issue 2693193005: [Windows MSVC CFG] Turning on linker CFG for all. Removing CFG compile. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/win/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/tests/integration_tests/cfi_unittest_exe.cc
diff --git a/sandbox/win/tests/integration_tests/cfi_unittest_exe.cc b/sandbox/win/tests/integration_tests/cfi_unittest_exe.cc
index c4c1e40b5accacf453c684e7f36964b03f79b275..07e17ea583310344c222eed538caa9cfebf4ba35 100644
--- a/sandbox/win/tests/integration_tests/cfi_unittest_exe.cc
+++ b/sandbox/win/tests/integration_tests/cfi_unittest_exe.cc
@@ -220,9 +220,9 @@ bool FindSignature(BYTE* start, DWORD* offset_found) {
// The whole purpose of this unittest is to ensure that a failed CFG check in
// a Microsoft binary results in an exception. If CFG is not properly
// enabled for a process, no exception will be thrown.
-// This test EXE is built with
-// configs += [ "//build/config/win:win_msvc_cfg" ]
-// which should result in CFG enabled on the process.
+// All Chromium projects should be linked with "common_linker_setup" config
+// (build\config\win\BUILD.gn), which should result in CFG enabled on the
+// process.
//
// - The patches (x86 or x64) were carefully constructed to be valid and not
// mess up the executing instructions. Need to ensure that the CFG check
« no previous file with comments | « sandbox/win/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698