Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2693043006: ozone: Fix HardwareDisplayController::AddCrtc. (Closed)

Created:
3 years, 10 months ago by Daniele Castagna
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

ozone: Fix HardwareDisplayController::AddCrtc. crrev.com/2603863002 replaced ScopedPtrHashMap with unordered_map. The CL replaced the statement owned_hardware_planes_.add(drm, plane_list) with owned_hardware_planes_[drm.get()] = plane_list While ScopedPtrHashMap::add did nothing if the key was already present, the new operation on the unordered_map is now always resetting the list of planes every time the statement is executed. This new unintented behavior introduced a regression (crbug.com/687290). This CL restores the original intended behavior. BUG=687290 Review-Url: https://codereview.chromium.org/2693903003 Cr-Commit-Position: refs/heads/master@{#450125} (cherry picked from commit e2b768afd564f860a3dc32db6e0114ca6e0db9f6) Review-Url: https://codereview.chromium.org/2693043006 . Cr-Commit-Position: refs/branch-heads/2987@{#504} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/9e6372cfc110717015ac2249bf13961987536fca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M ui/ozone/platform/drm/gpu/hardware_display_controller.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Daniele Castagna
3 years, 10 months ago (2017-02-14 18:48:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9e6372cfc110717015ac2249bf13961987536fca.

Powered by Google App Engine
This is Rietveld 408576698