Chromium Code Reviews
Descriptionozone: Fix HardwareDisplayController::AddCrtc.
crrev.com/2603863002 replaced ScopedPtrHashMap with unordered_map.
The CL replaced the statement
owned_hardware_planes_.add(drm, plane_list)
with
owned_hardware_planes_[drm.get()] = plane_list
While ScopedPtrHashMap::add did nothing if the key was already present,
the new operation on the unordered_map is now always resetting the list
of planes every time the statement is executed. This new unintented
behavior introduced a regression (crbug.com/687290).
This CL restores the original intended behavior.
BUG=687290
Review-Url: https://codereview.chromium.org/2693903003
Cr-Commit-Position: refs/heads/master@{#450125}
(cherry picked from commit e2b768afd564f860a3dc32db6e0114ca6e0db9f6)
Review-Url: https://codereview.chromium.org/2693043006 .
Cr-Commit-Position: refs/branch-heads/2987@{#504}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/9e6372cfc110717015ac2249bf13961987536fca
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||