ozone: Fix HardwareDisplayController::AddCrtc.

ozone: Fix HardwareDisplayController::AddCrtc.

crrev.com/2603863002 replaced ScopedPtrHashMap with unordered_map.

The CL replaced the statement
  owned_hardware_planes_.add(drm, plane_list)
with
  owned_hardware_planes_[drm.get()] = plane_list

While ScopedPtrHashMap::add did nothing if the key was already present,
the new operation on the unordered_map is now always resetting the list
of planes every time the statement is executed. This new unintented
behavior introduced a regression (crbug.com/687290).

This CL restores the original intended behavior.

BUG=687290
Review-Url: https://codereview.chromium.org/2693903003
Cr-Commit-Position: refs/heads/master@{#450125}
Committed: https://chromium.googlesource.com/chromium/src/+/e2b768afd564f860a3dc32db6e0114ca6e0db9f6

[Daniele Castagna, 2017-02-13 20:26:28]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 20:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2017-02-13 20:28:42]

dcastagna@chromium.org changed reviewers:
+ avi@chromium.org, rjkroege@chromium.org

[Daniele Castagna, 2017-02-13 20:32:58]

Description was changed from

==========
ozone: Fix HardwareDisplayController::AddCrtc.

crrev.com/2603863002 replaced ScopedPtrHashMap with unordered_map.

The CL replaced the statement
  owned_hardware_planes_.add(drm, plane_list)
with
  owned_hardware_planes_[drm.get()] = plane_list

While ScopedPtrHashMap::add did nothing if the key was already present,
the new operation on the unordered_map is now always resetting the list
of planes every the statement is executed. This new unintented behavior
introduced a regression (crbug.com/687290).

This CL restores the original intended behavior.

BUG=687290
==========

to

==========
ozone: Fix HardwareDisplayController::AddCrtc.

crrev.com/2603863002 replaced ScopedPtrHashMap with unordered_map.

The CL replaced the statement
  owned_hardware_planes_.add(drm, plane_list)
with
  owned_hardware_planes_[drm.get()] = plane_list

While ScopedPtrHashMap::add did nothing if the key was already present,
the new operation on the unordered_map is now always resetting the list
of planes every time the statement is executed. This new unintented
behavior introduced a regression (crbug.com/687290).

This CL restores the original intended behavior.

BUG=687290
==========

[Avi (use Gerrit), 2017-02-13 20:49:09]

Yes, of course. LGTM

Apologies for the regression.

[rjkroege, 2017-02-13 20:50:54]

lgtm

[commit-bot: I haz the power, 2017-02-13 22:32:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 22:32:12]

Dry run: This issue passed the CQ dry run.

[Daniele Castagna, 2017-02-13 22:33:27]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2017-02-13 22:34:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 22:41:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487025207268870, "parent_rev":
"1b4d28430e901f64aa5727490a3768bb25f3139e", "commit_rev":
"e2b768afd564f860a3dc32db6e0114ca6e0db9f6"}

[commit-bot: I haz the power, 2017-02-13 22:42:10]

Description was changed from

==========
ozone: Fix HardwareDisplayController::AddCrtc.

crrev.com/2603863002 replaced ScopedPtrHashMap with unordered_map.

The CL replaced the statement
  owned_hardware_planes_.add(drm, plane_list)
with
  owned_hardware_planes_[drm.get()] = plane_list

While ScopedPtrHashMap::add did nothing if the key was already present,
the new operation on the unordered_map is now always resetting the list
of planes every time the statement is executed. This new unintented
behavior introduced a regression (crbug.com/687290).

This CL restores the original intended behavior.

BUG=687290
==========

to

==========
ozone: Fix HardwareDisplayController::AddCrtc.

crrev.com/2603863002 replaced ScopedPtrHashMap with unordered_map.

The CL replaced the statement
  owned_hardware_planes_.add(drm, plane_list)
with
  owned_hardware_planes_[drm.get()] = plane_list

While ScopedPtrHashMap::add did nothing if the key was already present,
the new operation on the unordered_map is now always resetting the list
of planes every time the statement is executed. This new unintented
behavior introduced a regression (crbug.com/687290).

This CL restores the original intended behavior.

BUG=687290

Review-Url: https://codereview.chromium.org/2693903003
Cr-Commit-Position: refs/heads/master@{#450125}
Committed:
https://chromium.googlesource.com/chromium/src/+/e2b768afd564f860a3dc32db6e01...
==========

[commit-bot: I haz the power, 2017-02-13 22:42:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e2b768afd564f860a3dc32db6e01...