cc/output/gl_renderer.h - Issue 2693023002: Use SwapBuffersWithBounds on Chromecast

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/gl_renderer.h

Issue 2693023002: Use SwapBuffersWithBounds on Chromecast (Closed)

Patch Set: Address danakj comments on PS1 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/gl_renderer.h

diff --git a/cc/output/gl_renderer.h b/cc/output/gl_renderer.h

index ea73b6f881e7d7958bedf7afcb51bf3141c0340f..20bf49a49797805250e2f80ce269315dae34ff80 100644

--- a/cc/output/gl_renderer.h

+++ b/cc/output/gl_renderer.h

@@ -350,6 +350,7 @@ class CC_EXPORT GLRenderer : public DirectRenderer {

ColorLUTCache color_lut_cache_;

bool use_occlusion_query_;

+ bool use_swap_with_bounds_;

danakj 2017/02/16 18:54:19 can you group these two use_ with the other use_ a

danakj 2017/02/16 18:54:19 can be const

halliwell 2017/02/23 18:01:46 I grouped them. Making them all const is a bit ve

danakj 2017/02/24 22:05:18 Ah, right, good points, what u did seems good

unsigned offscreen_stencil_renderbuffer_id_ = 0;

gfx::Size offscreen_stencil_renderbuffer_size_;