Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: cc/output/gl_renderer.h

Issue 2693023002: Use SwapBuffersWithBounds on Chromecast (Closed)
Patch Set: Address danakj comments on PS1 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2010 The Chromium Authors. All rights reserved. 1 // Copyright 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_OUTPUT_GL_RENDERER_H_ 5 #ifndef CC_OUTPUT_GL_RENDERER_H_
6 #define CC_OUTPUT_GL_RENDERER_H_ 6 #define CC_OUTPUT_GL_RENDERER_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 332 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 // with a DrawingFrame is flipped. It makes the assumption that the 343 // with a DrawingFrame is flipped. It makes the assumption that the
344 // DrawingFrame is being used as part of a render pass. If a DrawingFrame is 344 // DrawingFrame is being used as part of a render pass. If a DrawingFrame is
345 // not being used as part of a render pass, setting it here forces 345 // not being used as part of a render pass, setting it here forces
346 // FlippedFramebuffer to return |true|. 346 // FlippedFramebuffer to return |true|.
347 bool force_drawing_frame_framebuffer_unflipped_ = false; 347 bool force_drawing_frame_framebuffer_unflipped_ = false;
348 348
349 BoundGeometry bound_geometry_; 349 BoundGeometry bound_geometry_;
350 ColorLUTCache color_lut_cache_; 350 ColorLUTCache color_lut_cache_;
351 351
352 bool use_occlusion_query_; 352 bool use_occlusion_query_;
353 bool use_swap_with_bounds_;
danakj 2017/02/16 18:54:19 can you group these two use_ with the other use_ a
danakj 2017/02/16 18:54:19 can be const
halliwell 2017/02/23 18:01:46 I grouped them. Making them all const is a bit ve
danakj 2017/02/24 22:05:18 Ah, right, good points, what u did seems good
353 unsigned offscreen_stencil_renderbuffer_id_ = 0; 354 unsigned offscreen_stencil_renderbuffer_id_ = 0;
354 gfx::Size offscreen_stencil_renderbuffer_size_; 355 gfx::Size offscreen_stencil_renderbuffer_size_;
355 356
356 base::WeakPtrFactory<GLRenderer> weak_ptr_factory_; 357 base::WeakPtrFactory<GLRenderer> weak_ptr_factory_;
357 358
358 DISALLOW_COPY_AND_ASSIGN(GLRenderer); 359 DISALLOW_COPY_AND_ASSIGN(GLRenderer);
359 }; 360 };
360 361
361 } // namespace cc 362 } // namespace cc
362 363
363 #endif // CC_OUTPUT_GL_RENDERER_H_ 364 #endif // CC_OUTPUT_GL_RENDERER_H_
OLDNEW
« no previous file with comments | « cc/output/direct_renderer.cc ('k') | cc/output/gl_renderer.cc » ('j') | cc/output/gl_renderer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698