Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2692993008: [Sync] Reset ModelTypeStore's leveldb database after corruption (Closed)

Created:
3 years, 10 months ago by pavely
Modified:
3 years, 10 months ago
Reviewers:
Patrick Noland
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Sync] Reset ModelTypeStore's leveldb database after corruption The issue is that once leveldb database is corrupt it will keep failing initialization. I decided to reset database instead of attempting to recover it because recover doesn't seem to guarantee consistency of data. R=pnoland@chromium.org BUG=684774 Review-Url: https://codereview.chromium.org/2682063004 Cr-Commit-Position: refs/heads/master@{#450423} (cherry picked from commit 323b23d6a1ebe7f3d6ed581b6ef7334c6207460b) Review-Url: https://codereview.chromium.org/2692993008 . Cr-Commit-Position: refs/branch-heads/2987@{#531} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/2e69e04e27c0e5d763bdf30b9cb696d0269dd302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -59 lines) Patch
M components/sync/model_impl/model_type_store_backend.h View 5 chunks +58 lines, -19 lines 0 comments Download
M components/sync/model_impl/model_type_store_backend.cc View 5 chunks +46 lines, -40 lines 0 comments Download
M components/sync/model_impl/model_type_store_backend_unittest.cc View 4 chunks +66 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pavely
3 years, 10 months ago (2017-02-15 20:45:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2e69e04e27c0e5d763bdf30b9cb696d0269dd302.

Powered by Google App Engine
This is Rietveld 408576698