[Sync] Reset ModelTypeStore's leveldb database after corruption

[Sync] Reset ModelTypeStore's leveldb database after corruption

The issue is that once leveldb database is corrupt it will keep failing
initialization.

I decided to reset database instead of attempting to recover it because recover
doesn't seem to guarantee consistency of data.

R=pnoland@chromium.org
BUG=684774
Review-Url: https://codereview.chromium.org/2682063004
Cr-Commit-Position: refs/heads/master@{#450423}
Committed: https://chromium.googlesource.com/chromium/src/+/323b23d6a1ebe7f3d6ed581b6ef7334c6207460b

[pavely, 2017-02-09 19:59:34]

The CQ bit was checked by pavely@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 20:00:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pavely, 2017-02-09 20:00:21]

Description was changed from

==========
[Sync] Reset ModelTypeStore's leveldb database after corruption

The issue is that once leveldb database is corrupt it will keep failing
initialization.

I decided to reset database instead of attempting to recover it because recover
doesn't seem to guarantee consistency of data.

R=pnoland@chromium.org
BUG=684774
==========

to

==========
[Sync] Reset ModelTypeStore's leveldb database after corruption

The issue is that once leveldb database is corrupt it will keep failing
initialization.

I decided to reset database instead of attempting to recover it because recover
doesn't seem to guarantee consistency of data.

R=pnoland@chromium.org
BUG=684774
==========

[pavely, 2017-02-09 20:00:21]

pavely@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[pavely, 2017-02-09 20:01:28]

Patrick, PTAL. 
Eric, could you review histograms.xml change.

[Patrick Noland, 2017-02-09 20:24:52]

lgtm

https://codereview.chromium.org/2682063004/diff/1/components/sync/model_impl/...
File components/sync/model_impl/model_type_store_backend.h (right):

https://codereview.chromium.org/2682063004/diff/1/components/sync/model_impl/...
components/sync/model_impl/model_type_store_backend.h:116: leveldb::Status
DestroyDatabase(const std::string& path, leveldb::Env* env);
Can you add a comment for DestroyDatabase?

[commit-bot: I haz the power, 2017-02-09 21:07:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 21:07:50]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pavely, 2017-02-09 21:19:19]

https://codereview.chromium.org/2682063004/diff/1/components/sync/model_impl/...
File components/sync/model_impl/model_type_store_backend.h (right):

https://codereview.chromium.org/2682063004/diff/1/components/sync/model_impl/...
components/sync/model_impl/model_type_store_backend.h:116: leveldb::Status
DestroyDatabase(const std::string& path, leveldb::Env* env);
On 2017/02/09 20:24:52, Patrick Noland wrote:
> Can you add a comment for DestroyDatabase?

Done.

[Eric Willigers, 2017-02-09 22:07:37]

ericwilligers@chromium.org changed reviewers:
+ jwd@chromium.org
- ericwilligers@chromium.org

[Eric Willigers, 2017-02-09 22:07:38]

+jwd for histogram change

[pavely, 2017-02-09 22:08:44]

Patchset #3 (id:40001) has been deleted

[pavely, 2017-02-11 19:06:49]

Patchset #3 (id:60001) has been deleted

[pavely, 2017-02-13 07:18:02]

The CQ bit was checked by pavely@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 07:18:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 08:10:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 08:10:14]

Dry run: This issue passed the CQ dry run.

[pavely, 2017-02-13 17:08:08]

Jesse, could you review histograms.xml change?

[jwd, 2017-02-14 16:00:53]

lgtm

[pavely, 2017-02-14 17:39:14]

The CQ bit was checked by pavely@chromium.org

[pavely, 2017-02-14 17:39:15]

The patchset sent to the CQ was uploaded after l-g-t-m from pnoland@chromium.org
Link to the patchset: https://codereview.chromium.org/2682063004/#ps80001
(title: "Fix windows tests")

[commit-bot: I haz the power, 2017-02-14 17:39:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 18:50:05]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487093954986610,
"parent_rev": "00e934cfb7e965d9f37193aaa1adc685e1ed7d82", "commit_rev":
"323b23d6a1ebe7f3d6ed581b6ef7334c6207460b"}

[commit-bot: I haz the power, 2017-02-14 18:50:42]

Description was changed from

==========
[Sync] Reset ModelTypeStore's leveldb database after corruption

The issue is that once leveldb database is corrupt it will keep failing
initialization.

I decided to reset database instead of attempting to recover it because recover
doesn't seem to guarantee consistency of data.

R=pnoland@chromium.org
BUG=684774
==========

to

==========
[Sync] Reset ModelTypeStore's leveldb database after corruption

The issue is that once leveldb database is corrupt it will keep failing
initialization.

I decided to reset database instead of attempting to recover it because recover
doesn't seem to guarantee consistency of data.

R=pnoland@chromium.org
BUG=684774

Review-Url: https://codereview.chromium.org/2682063004
Cr-Commit-Position: refs/heads/master@{#450423}
Committed:
https://chromium.googlesource.com/chromium/src/+/323b23d6a1ebe7f3d6ed581b6ef7...
==========

[commit-bot: I haz the power, 2017-02-14 18:50:43]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/323b23d6a1ebe7f3d6ed581b6ef7...