DevTools: do not search in anonymous scripts unless specifically asked for.

DevTools: do not search in anonymous scripts unless specifically asked for.

Today, the "search across all files" searches not only all sources
of the website, but also all ever-evaluated scripts.
This helps in certain kind of investigations, e.g. to find
anonymously-evaluated script which did some page modifications.

Most of the time, however, the "search across all files" is used to search
across the resources of the application. In this case, searching across all
scripts might become slow, especially since certain websites generate
a lot of scripts via eval().

This patch removes old "search in content scripts" setting and adds a new one:
"Search in dynamic scripts and extensions". With this setting on,
the "Search across all files" will search in both content scripts and
dynamically-added anonymous scripts. Otherwise, only named resources
will be searched.

BUG=680205
R=pfeldman, dgozman

Review-Url: https://codereview.chromium.org/2692923013
Cr-Commit-Position: refs/heads/master@{#452253}
Committed: https://chromium.googlesource.com/chromium/src/+/ceabef6794ee9885b0a3f52f5c948a8bee079a2c

[lushnikov, 2017-02-18 00:44:22]

please, take a look

[lushnikov, 2017-02-18 00:44:27]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-18 00:45:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 02:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 02:47:24]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[dgozman, 2017-02-18 20:37:59]

Should we expose this in search view instead?
For example, "search everywhere" button/checkbox with explanation of resources
vs. all scripts (can use styles from rendering drawer pane).
Or a link "Expect more results? Search in anonymous resources" which appears
below search results after the quick search is performed.
WDYT?

[lushnikov, 2017-02-18 20:57:59]

Exposing this setting in the UI will surely bring more visibility, though I'm
not sure it is needed.
I have a feeling that absolute majority of our users are not interested in this
scenario, and that it can
even confuse them.

Let's discuss this off-line on tuesday!

[lushnikov, 2017-02-22 02:45:56]

(bumping this per @dgozman's request)

[dgozman, 2017-02-22 20:17:06]

lgtm

https://codereview.chromium.org/2692923013/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js
(right):

https://codereview.chromium.org/2692923013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js:80:
.filter(project => project.type() !== Workspace.projectTypes.Service)
I personally don't like chaining multiple calls doing the same thing. Can we
have a single filter function which would check all the conditions instead?

https://codereview.chromium.org/2692923013/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/module.json (right):

https://codereview.chromium.org/2692923013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/module.json:378: "title":
"Search in dynamic scripts and extensions",
Search in anonymous and content scripts

https://codereview.chromium.org/2692923013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/module.json:379:
"settingName": "searchInDynamicScriptsAndExtensions",
searchInAnonymousAndContentScripts

[lushnikov, 2017-02-22 21:22:37]

https://codereview.chromium.org/2692923013/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js
(right):

https://codereview.chromium.org/2692923013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js:80:
.filter(project => project.type() !== Workspace.projectTypes.Service)
On 2017/02/22 20:17:06, dgozman wrote:
> I personally don't like chaining multiple calls doing the same thing. Can we
> have a single filter function which would check all the conditions instead?

Done.

https://codereview.chromium.org/2692923013/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/module.json (right):

https://codereview.chromium.org/2692923013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/module.json:378: "title":
"Search in dynamic scripts and extensions",
On 2017/02/22 20:17:06, dgozman wrote:
> Search in anonymous and content scripts

Done.

https://codereview.chromium.org/2692923013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/module.json:379:
"settingName": "searchInDynamicScriptsAndExtensions",
On 2017/02/22 20:17:06, dgozman wrote:
> searchInAnonymousAndContentScripts

Done.

[lushnikov, 2017-02-22 21:22:43]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-02-22 21:22:44]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2692923013/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2017-02-22 21:23:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 22:57:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487798563665310,
"parent_rev": "08b74323568c102885a43073f95765b53f700ab8", "commit_rev":
"ceabef6794ee9885b0a3f52f5c948a8bee079a2c"}

[commit-bot: I haz the power, 2017-02-22 22:57:47]

Description was changed from

==========
DevTools: do not search in anonymous scripts unless specifically asked for.

Today, the "search across all files" searches not only all sources
of the website, but also all ever-evaluated scripts.
This helps in certain kind of investigations, e.g. to find
anonymously-evaluated script which did some page modifications.

Most of the time, however, the "search across all files" is used to search
across the resources of the application. In this case, searching across all
scripts might become slow, especially since certain websites generate
a lot of scripts via eval().

This patch removes old "search in content scripts" setting and adds a new one:
"Search in dynamic scripts and extensions". With this setting on,
the "Search across all files" will search in both content scripts and
dynamically-added anonymous scripts. Otherwise, only named resources
will be searched.

BUG=680205
R=pfeldman, dgozman
==========

to

==========
DevTools: do not search in anonymous scripts unless specifically asked for.

Today, the "search across all files" searches not only all sources
of the website, but also all ever-evaluated scripts.
This helps in certain kind of investigations, e.g. to find
anonymously-evaluated script which did some page modifications.

Most of the time, however, the "search across all files" is used to search
across the resources of the application. In this case, searching across all
scripts might become slow, especially since certain websites generate
a lot of scripts via eval().

This patch removes old "search in content scripts" setting and adds a new one:
"Search in dynamic scripts and extensions". With this setting on,
the "Search across all files" will search in both content scripts and
dynamically-added anonymous scripts. Otherwise, only named resources
will be searched.

BUG=680205
R=pfeldman, dgozman

Review-Url: https://codereview.chromium.org/2692923013
Cr-Commit-Position: refs/heads/master@{#452253}
Committed:
https://chromium.googlesource.com/chromium/src/+/ceabef6794ee9885b0a3f52f5c94...
==========

[commit-bot: I haz the power, 2017-02-22 22:57:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ceabef6794ee9885b0a3f52f5c94...