third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js - Issue 2692923013: DevTools: do not search in anonymous scripts unless specifically asked for.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

Issue 2692923013: DevTools: do not search in anonymous scripts unless specifically asked for. (Closed)

Patch Set: address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/common/Settings.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js b/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

index bfc38dffe0a91bc001b762af4bf593b0398af176..513ca1c89511387e4a63b14090f23a0409f90040 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

@@ -154,7 +154,7 @@ Sources.AdvancedSearchView = class extends UI.VBox {

if (!searchResult.searchMatches.length)

return;

if (!this._searchResultsPane)

- this._searchResultsPane = this._searchScope.createSearchResultsPane(this._searchConfig);

+ this._searchResultsPane = new Sources.FileBasedSearchResultsPane(this._searchConfig);

this._resetResults();

this._searchResultsElement.appendChild(this._searchResultsPane.element);

this._searchResultsPane.addSearchResult(searchResult);

@@ -435,11 +435,5 @@ Sources.SearchScope.prototype = {

performIndexing(progress) {},

- stopSearch() {},

- /**

- * @param {!Workspace.ProjectSearchConfig} searchConfig

- * @return {!Sources.SearchResultsPane}

- */

- createSearchResultsPane(searchConfig) {}

+ stopSearch() {}

};