Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2692883003: Actually delegate in additional FilterEffectBuilder constructor (Closed)

Created:
3 years, 10 months ago by fs
Modified:
3 years, 10 months ago
Reviewers:
fserb
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Actually delegate in additional FilterEffectBuilder constructor Because url(...) filters are ignored/dropped this will not have any practical effect, but could avoid issues in the future. BUG=593838 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2692883003 Cr-Commit-Position: refs/heads/master@{#450374} Committed: https://chromium.googlesource.com/chromium/src/+/57b186697a33b7e1eb969995fd9174d9a43048fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
fs
3 years, 10 months ago (2017-02-14 13:42:01 UTC) #5
fserb
lgtm
3 years, 10 months ago (2017-02-14 16:14:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692883003/1
3 years, 10 months ago (2017-02-14 16:14:38 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 16:20:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/57b186697a33b7e1eb969995fd91...

Powered by Google App Engine
This is Rietveld 408576698