Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp

Issue 2692883003: Actually delegate in additional FilterEffectBuilder constructor (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Google Inc. All rights reserved. 3 * Copyright (C) 2013 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 116
117 lastMatrixRow(matrix); 117 lastMatrixRow(matrix);
118 return matrix; 118 return matrix;
119 } 119 }
120 120
121 } // namespace 121 } // namespace
122 122
123 FilterEffectBuilder::FilterEffectBuilder(const FloatRect& zoomedReferenceBox, 123 FilterEffectBuilder::FilterEffectBuilder(const FloatRect& zoomedReferenceBox,
124 float zoom, 124 float zoom,
125 const SkPaint* fillPaint, 125 const SkPaint* fillPaint,
126 const SkPaint* strokePaint) { 126 const SkPaint* strokePaint)
127 FilterEffectBuilder(nullptr, zoomedReferenceBox, zoom, fillPaint, 127 : FilterEffectBuilder(nullptr,
128 strokePaint); 128 zoomedReferenceBox,
129 } 129 zoom,
130 fillPaint,
131 strokePaint) {}
130 132
131 FilterEffectBuilder::FilterEffectBuilder(Node* target, 133 FilterEffectBuilder::FilterEffectBuilder(Node* target,
132 const FloatRect& zoomedReferenceBox, 134 const FloatRect& zoomedReferenceBox,
133 float zoom, 135 float zoom,
134 const PaintFlags* fillPaint, 136 const PaintFlags* fillPaint,
135 const PaintFlags* strokePaint) 137 const PaintFlags* strokePaint)
136 : m_targetContext(target), 138 : m_targetContext(target),
137 m_referenceBox(zoomedReferenceBox), 139 m_referenceBox(zoomedReferenceBox),
138 m_zoom(zoom), 140 m_zoom(zoom),
139 m_fillPaint(fillPaint), 141 m_fillPaint(fillPaint),
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
438 Filter::create(m_referenceBox, filterRegion, m_zoom, unitScaling); 440 Filter::create(m_referenceBox, filterRegion, m_zoom, unitScaling);
439 if (!previousEffect) 441 if (!previousEffect)
440 previousEffect = result->getSourceGraphic(); 442 previousEffect = result->getSourceGraphic();
441 SVGFilterBuilder builder(previousEffect, nodeMap, m_fillPaint, m_strokePaint); 443 SVGFilterBuilder builder(previousEffect, nodeMap, m_fillPaint, m_strokePaint);
442 builder.buildGraph(result, filterElement, m_referenceBox); 444 builder.buildGraph(result, filterElement, m_referenceBox);
443 result->setLastEffect(builder.lastEffect()); 445 result->setLastEffect(builder.lastEffect());
444 return result; 446 return result;
445 } 447 }
446 448
447 } // namespace blink 449 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698