Issue 2692873002: binding: Sets location[Symbol.toPrimitive].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2692873002: binding: Sets location[Symbol.toPrimitive]. (Closed)

Created:
3 years, 10 months ago by Yuki

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

binding: Sets location[Symbol.toPrimitive]. Let the location objects have Symbol.toPrimitive property as an unconfiguable own property, so that author scripts cannot inject nor overwrite it. BUG=680409 Review-Url: https://codereview.chromium.org/2656973002 Cr-Commit-Position: refs/heads/master@{#446991} (cherry picked from commit 1f959adce3efa86d7d9560f9642c6ae816f8d81c) Review-Url: https://codereview.chromium.org/2692873002 . Cr-Commit-Position: refs/branch-heads/2987@{#472} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/601b6bfa2b363e4c1acc4ab599f30ccde43b8a06

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -0 lines)			Patch
	A	third_party/WebKit/LayoutTests/fast/dom/location-toprimitive.html	View		1 chunk	+32 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Yuki

3 years, 10 months ago (2017-02-13 12:49:14 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
601b6bfa2b363e4c1acc4ab599f30ccde43b8a06.