Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2656973002: binding: Sets location[Symbol.toPrimitive]. (Closed)

Created:
3 years, 11 months ago by Yuki
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Sets location[Symbol.toPrimitive]. Let the location objects have Symbol.toPrimitive property as an unconfiguable own property, so that author scripts cannot inject nor overwrite it. BUG=680409 Review-Url: https://codereview.chromium.org/2656973002 Cr-Commit-Position: refs/heads/master@{#446991} Committed: https://chromium.googlesource.com/chromium/src/+/1f959adce3efa86d7d9560f9642c6ae816f8d81c

Patch Set 1 #

Patch Set 2 : Synced. #

Patch Set 3 : Added a layout test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/location-toprimitive.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Yuki
Could you review this CL?
3 years, 10 months ago (2017-01-30 08:35:39 UTC) #6
haraken
LGTM Can we add a test?
3 years, 10 months ago (2017-01-30 09:36:42 UTC) #7
Yuki
Agreed. Added a layout test.
3 years, 10 months ago (2017-01-30 14:04:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656973002/40001
3 years, 10 months ago (2017-01-30 14:05:18 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 16:06:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1f959adce3efa86d7d9560f9642c...

Powered by Google App Engine
This is Rietveld 408576698