Change PaintLayer::m_layoutObject to a reference.

Change PaintLayer::m_layoutObject to a reference.

PaintLayer::layoutObject() and CompositedLayerMapping::layoutObject()
now return references, and various other methods now take references
rather than pointers as arguments.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2692853016
Cr-Commit-Position: refs/heads/master@{#451361}
Committed: https://chromium.googlesource.com/chromium/src/+/f903348fa83ee0e48eb45a1b850bcd16ab230392

[szager1, 2017-02-17 09:12:22]

Description was changed from

==========
Change PaintLayer::m_layoutObject to a reference.
==========

to

==========
Change PaintLayer::m_layoutObject to a reference.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[szager1, 2017-02-17 09:12:40]

The CQ bit was checked by szager@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 09:12:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 09:49:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 09:49:24]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[szager1, 2017-02-17 09:57:27]

The CQ bit was checked by szager@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 09:57:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[szager1, 2017-02-17 09:59:29]

Description was changed from

==========
Change PaintLayer::m_layoutObject to a reference.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Change PaintLayer::m_layoutObject to a reference.

This ripples through a few method interfaces, in particular
PaintLayer::layoutObject() and CompositedLayerMapping::layoutObject().

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[szager1, 2017-02-17 10:02:44]

Description was changed from

==========
Change PaintLayer::m_layoutObject to a reference.

This ripples through a few method interfaces, in particular
PaintLayer::layoutObject() and CompositedLayerMapping::layoutObject().

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Change PaintLayer::m_layoutObject to a reference.

PaintLayer::layoutObject() and CompositedLayerMapping::layoutObject() now return
references, and various other methods now take references rather than pointers
as arguments.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-02-17 12:04:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 12:04:09]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[szager1, 2017-02-17 16:17:53]

szager@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[szager1, 2017-02-17 16:19:03]

Description was changed from

==========
Change PaintLayer::m_layoutObject to a reference.

PaintLayer::layoutObject() and CompositedLayerMapping::layoutObject() now return
references, and various other methods now take references rather than pointers
as arguments.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Change PaintLayer::m_layoutObject to a reference.

PaintLayer::layoutObject() and CompositedLayerMapping::layoutObject()
now return references, and various other methods now take references
rather than pointers as arguments.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-02-17 17:23:07]

https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (left):

https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:579: if
(!transformedAncestor)
ditto

https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):

https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:557:
paintInvalidationLayer->enclosingTransformedAncestor()->layoutObject();
This looks like a bug in the old code. I think it's supposed to be:

LayoutBoxModelObject*  transformedAncestor =
paintInvalidationLayer->enclosingTransformedAncestor();

if (!transformedAncestor)
  return;

[chrishtr, 2017-02-17 17:24:07]

https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):

https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:557:
paintInvalidationLayer->enclosingTransformedAncestor()->layoutObject();
On 2017/02/17 at 17:23:07, chrishtr wrote:
> This looks like a bug in the old code. I think it's supposed to be:
> 
> LayoutBoxModelObject*  transformedAncestor =
paintInvalidationLayer->enclosingTransformedAncestor();
> 
> if (!transformedAncestor)
>   return;

Make that:

PaintLayer*  transformedAncestorPaintLayer =
paintInvalidationLayer->enclosingTransformedAncestor();
if (!transformedAncestorPaintLayer)
   return;

[pdr., 2017-02-17 17:37:09]

LGTM

[szager1, 2017-02-17 18:06:26]

https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):

https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:557:
paintInvalidationLayer->enclosingTransformedAncestor()->layoutObject();
On 2017/02/17 17:24:07, chrishtr wrote:
> On 2017/02/17 at 17:23:07, chrishtr wrote:
> > This looks like a bug in the old code. I think it's supposed to be:
> > 
> > LayoutBoxModelObject*  transformedAncestor =
> paintInvalidationLayer->enclosingTransformedAncestor();
> > 
> > if (!transformedAncestor)
> >   return;
> 
> Make that:
> 
> PaintLayer*  transformedAncestorPaintLayer =
> paintInvalidationLayer->enclosingTransformedAncestor();
> if (!transformedAncestorPaintLayer)
>    return;

How about putting this in a separate patch?  I don't want to mix functional
changes into this big refactor.

[chrishtr, 2017-02-17 18:08:37]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-02-17 18:08:38]

lgtm

Ok just add a todo.

[chrishtr, 2017-02-17 18:08:54]

The CQ bit was unchecked by chrishtr@chromium.org

[szager1, 2017-02-17 18:17:34]

The CQ bit was checked by szager@chromium.org

[szager1, 2017-02-17 18:17:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2692853016/#ps40001
(title: "Added TODO")

[szager1, 2017-02-17 18:18:03]

On 2017/02/17 18:08:38, chrishtr wrote:
> lgtm
> 
> Ok just add a todo.

I added them as TODO(chrishtr), because I don't like to make changes I don't
understand.

[commit-bot: I haz the power, 2017-02-17 18:18:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 19:57:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487355454079270,
"parent_rev": "313016af0d837cfcc8ee3ccd19145f46eebc0b10", "commit_rev":
"f903348fa83ee0e48eb45a1b850bcd16ab230392"}

[commit-bot: I haz the power, 2017-02-17 19:58:23]

Description was changed from

==========
Change PaintLayer::m_layoutObject to a reference.

PaintLayer::layoutObject() and CompositedLayerMapping::layoutObject()
now return references, and various other methods now take references
rather than pointers as arguments.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Change PaintLayer::m_layoutObject to a reference.

PaintLayer::layoutObject() and CompositedLayerMapping::layoutObject()
now return references, and various other methods now take references
rather than pointers as arguments.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2692853016
Cr-Commit-Position: refs/heads/master@{#451361}
Committed:
https://chromium.googlesource.com/chromium/src/+/f903348fa83ee0e48eb45a1b850b...
==========

[commit-bot: I haz the power, 2017-02-17 19:58:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f903348fa83ee0e48eb45a1b850b...