third_party/WebKit/Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp - Issue 2692853016: Change PaintLayer::m_layoutObject to a reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp

Issue 2692853016: Change PaintLayer::m_layoutObject to a reference. (Closed)

Patch Set: Added TODO Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp b/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp

index 51ffead721e65061681dff0ba91607aea1ff4c79..9eea8cc8647b9533061cf2b53e388bb0dd60c703 100644

--- a/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp

@@ -40,7 +40,7 @@ GraphicsLayerTreeBuilder::GraphicsLayerTreeBuilder() {}

GraphicsLayerTreeBuilder::~GraphicsLayerTreeBuilder() {}

static bool shouldAppendLayer(const PaintLayer& layer) {

- Node* node = layer.layoutObject()->node();

+ Node* node = layer.layoutObject().node();

if (node && isHTMLVideoElement(*node)) {

HTMLVideoElement* element = toHTMLVideoElement(node);

if (element->isFullscreen() && element->usesOverlayFullscreenVideo())

@@ -94,7 +94,7 @@ void GraphicsLayerTreeBuilder::rebuild(PaintLayer& layer,

if (hasCompositedLayerMapping) {

bool parented = false;

- if (layer.layoutObject()->isLayoutPart())

+ if (layer.layoutObject().isLayoutPart())

parented = PaintLayerCompositor::attachFrameContentLayersToIframeLayer(

toLayoutPart(layer.layoutObject()));