Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Issue 2692773002: [merge-m57] Ensure the line on the origin info bubble extends the full width of the bubble. (Closed)

Created:
3 years, 10 months ago by tapted
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[merge-m57] Ensure the line on the origin info bubble extends the full width of the bubble. This regressed in r444474 which was necessary to adapt the bubble margins to support Harmony layout (i.e. since margins are no longer a compile-time constant). The separator line, however, needs to ignore the margins completely. So move the bubble margin into the classes doing layout above and below the separator. BUG=689574 Review-Url: https://codereview.chromium.org/2686983002 Cr-Commit-Position: refs/heads/master@{#449222} (cherry picked from commit 3b76fcf9516aed2d90a61ae035cfdf2b2a18e08c) Review-Url: https://codereview.chromium.org/2692773002 . Cr-Commit-Position: refs/branch-heads/2987@{#467} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/39df7ec4a3cf18ffd93ac26ab1472d5031f4b9d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -19 lines) Patch
M chrome/browser/ui/views/website_settings/website_settings_popup_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 8 chunks +35 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tapted
3 years, 10 months ago (2017-02-12 22:50:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
39df7ec4a3cf18ffd93ac26ab1472d5031f4b9d5.

Powered by Google App Engine
This is Rietveld 408576698