Ensure the line on the origin info bubble extends the full width of the bubble.

Ensure the line on the origin info bubble extends the full width of the bubble.

This regressed in r444474 which was necessary to adapt the bubble
margins to support Harmony layout (i.e. since margins are no longer a
compile-time constant).

The separator line, however, needs to ignore the margins completely. So
move the bubble margin into the classes doing layout above and below the
separator.

BUG=689574
Review-Url: https://codereview.chromium.org/2686983002
Cr-Commit-Position: refs/heads/master@{#449222}
Committed: https://chromium.googlesource.com/chromium/src/+/3b76fcf9516aed2d90a61ae035cfdf2b2a18e08c

[tapted, 2017-02-09 00:40:47]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 00:41:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-02-09 00:48:19]

Description was changed from

==========
Ensure the line on the origin info bubble extends the full width of the bubble.



BUG=689574
==========

to

==========
Ensure the line on the origin info bubble extends the full width of the bubble.

This regressed in r444474 which was necessary to adapt the bubble
margins to support Harmony layout (i.e. they are no longer a
compile-time constant).

The separator line, however, needs to ignore the margins completely. So
move  the bubble margin into the classes doing layout above and below
the separator.

BUG=689574
==========

[tapted, 2017-02-09 00:48:19]

tapted@chromium.org changed reviewers:
+ benwells@chromium.org

[commit-bot: I haz the power, 2017-02-09 01:32:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 01:32:58]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-02-09 02:05:10]

Description was changed from

==========
Ensure the line on the origin info bubble extends the full width of the bubble.

This regressed in r444474 which was necessary to adapt the bubble
margins to support Harmony layout (i.e. they are no longer a
compile-time constant).

The separator line, however, needs to ignore the margins completely. So
move  the bubble margin into the classes doing layout above and below
the separator.

BUG=689574
==========

to

==========
Ensure the line on the origin info bubble extends the full width of the bubble.

This regressed in r444474 which was necessary to adapt the bubble
margins to support Harmony layout (i.e. they are no longer a
compile-time constant).

The separator line, however, needs to ignore the margins completely. So
move the bubble margin into the classes doing layout above and below
the separator.

BUG=689574
==========

[tapted, 2017-02-09 02:49:05]

Description was changed from

==========
Ensure the line on the origin info bubble extends the full width of the bubble.

This regressed in r444474 which was necessary to adapt the bubble
margins to support Harmony layout (i.e. they are no longer a
compile-time constant).

The separator line, however, needs to ignore the margins completely. So
move the bubble margin into the classes doing layout above and below
the separator.

BUG=689574
==========

to

==========
Ensure the line on the origin info bubble extends the full width of the bubble.

This regressed in r444474 which was necessary to adapt the bubble
margins to support Harmony layout (i.e. since margins are no longer a
compile-time constant).

The separator line, however, needs to ignore the margins completely. So
move the bubble margin into the classes doing layout above and below the
separator.

BUG=689574
==========

[tapted, 2017-02-09 02:55:31]

Hi Ben, could you please take a look? Screenshots/pixel-diffs at
http://crbug.com/689574#c2

Thanks!

[benwells, 2017-02-09 05:52:36]

lgtm

[tapted, 2017-02-09 05:59:12]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-02-09 05:59:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 06:17:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486619952208690,
"parent_rev": "7f9dcefa6e2a9ff89fa3e36887b7fe54910625b6", "commit_rev":
"3b76fcf9516aed2d90a61ae035cfdf2b2a18e08c"}

[commit-bot: I haz the power, 2017-02-09 06:17:45]

Description was changed from

==========
Ensure the line on the origin info bubble extends the full width of the bubble.

This regressed in r444474 which was necessary to adapt the bubble
margins to support Harmony layout (i.e. since margins are no longer a
compile-time constant).

The separator line, however, needs to ignore the margins completely. So
move the bubble margin into the classes doing layout above and below the
separator.

BUG=689574
==========

to

==========
Ensure the line on the origin info bubble extends the full width of the bubble.

This regressed in r444474 which was necessary to adapt the bubble
margins to support Harmony layout (i.e. since margins are no longer a
compile-time constant).

The separator line, however, needs to ignore the margins completely. So
move the bubble margin into the classes doing layout above and below the
separator.

BUG=689574

Review-Url: https://codereview.chromium.org/2686983002
Cr-Commit-Position: refs/heads/master@{#449222}
Committed:
https://chromium.googlesource.com/chromium/src/+/3b76fcf9516aed2d90a61ae035cf...
==========

[commit-bot: I haz the power, 2017-02-09 06:17:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3b76fcf9516aed2d90a61ae035cf...