[Bindings] Update runtime enabled features from partial interfaces

Makes it enable to update runtime enabled features (REFs) on the
instance of the base interface from a partial interface.


This CL is a follow-up of https://codereview.chromium.org/2622153002/


BUG=617892
Review-Url: https://codereview.chromium.org/2692753003
Cr-Commit-Position: refs/heads/master@{#449932}
Committed: https://chromium.googlesource.com/chromium/src/+/128197bbfc8d38eae9adf1f2e766683301c80097

[peria, 2017-02-13 08:18:25]

Description was changed from

==========
Update runtime enabled features function in partial interfaces

BUG=
==========

to

==========
Update runtime enabled feature functions on installing modules.
It needs to update partial interfaces' functions.

This CL is a follow-up of https://codereview.chromium.org/2622153002/

BUG=617892
==========

[peria, 2017-02-13 08:18:32]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 08:18:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-02-13 09:39:27]

Description was changed from

==========
Update runtime enabled feature functions on installing modules.
It needs to update partial interfaces' functions.

This CL is a follow-up of https://codereview.chromium.org/2622153002/

BUG=617892
==========

to

==========
Makes it enable to update runtime enabled features on the instance of 
the base interface from a partial interface.

This CL is a follow-up of https://codereview.chromium.org/2622153002/


BUG=617892
==========

[peria, 2017-02-13 09:47:41]

Description was changed from

==========
Makes it enable to update runtime enabled features on the instance of 
the base interface from a partial interface.

This CL is a follow-up of https://codereview.chromium.org/2622153002/


BUG=617892
==========

to

==========
Makes it enable to update runtime enabled features (REFs) on the
instance of the base interface from a partial interface.


This CL is a follow-up of https://codereview.chromium.org/2622153002/


BUG=617892
==========

[peria, 2017-02-13 09:47:58]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 09:48:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-02-13 09:48:28]

peria@chromium.org changed reviewers:
+ bashi@chromium.org, haraken@chromium.org, yukishiino@chromium.org

[peria, 2017-02-13 09:48:29]

PTL

[commit-bot: I haz the power, 2017-02-13 11:19:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 11:19:21]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-02-13 11:25:56]

LGTM

[peria, 2017-02-13 11:31:47]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2017-02-13 11:31:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 11:35:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486985507837880,
"parent_rev": "8d2ce8436e8687f243389f203804c8e078f7fbb2", "commit_rev":
"128197bbfc8d38eae9adf1f2e766683301c80097"}

[commit-bot: I haz the power, 2017-02-13 11:36:15]

Description was changed from

==========
Makes it enable to update runtime enabled features (REFs) on the
instance of the base interface from a partial interface.


This CL is a follow-up of https://codereview.chromium.org/2622153002/


BUG=617892
==========

to

==========
Makes it enable to update runtime enabled features (REFs) on the
instance of the base interface from a partial interface.


This CL is a follow-up of https://codereview.chromium.org/2622153002/


BUG=617892

Review-Url: https://codereview.chromium.org/2692753003
Cr-Commit-Position: refs/heads/master@{#449932}
Committed:
https://chromium.googlesource.com/chromium/src/+/128197bbfc8d38eae9adf1f2e766...
==========

[commit-bot: I haz the power, 2017-02-13 11:36:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/128197bbfc8d38eae9adf1f2e766...

[Yuki, 2017-02-13 12:15:03]

LGTM.

https://codereview.chromium.org/2692753003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8Binding.h (right):

https://codereview.chromium.org/2692753003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8Binding.h:1084: typedef void
(*InstallRuntimeEnabledFunction)(
nit: We don't need to expose this type to anything except for the code
generator.  GeneratedCodeHelper.h is the best place, I think.

https://codereview.chromium.org/2692753003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl (right):

https://codereview.chromium.org/2692753003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl:924:
InstallRuntimeEnabledFunction
{{v8_class}}::install{{v8_class}}RuntimeEnabledFunction =
(InstallRuntimeEnabledFunction)&{{v8_class}}::installRuntimeEnabledFeatures;
nit: Better avoid casting.

[peria, 2017-02-13 12:32:20]

On 2017/02/13 12:15:03, Yuki wrote:
> LGTM.
> 
>
https://codereview.chromium.org/2692753003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/bindings/core/v8/V8Binding.h (right):
> 
>
https://codereview.chromium.org/2692753003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/bindings/core/v8/V8Binding.h:1084: typedef void
> (*InstallRuntimeEnabledFunction)(
> nit: We don't need to expose this type to anything except for the code
> generator.  GeneratedCodeHelper.h is the best place, I think.
> 
>
https://codereview.chromium.org/2692753003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl (right):
> 
>
https://codereview.chromium.org/2692753003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl:924:
> InstallRuntimeEnabledFunction
> {{v8_class}}::install{{v8_class}}RuntimeEnabledFunction =
> (InstallRuntimeEnabledFunction)&{{v8_class}}::installRuntimeEnabledFeatures;
> nit: Better avoid casting.

Thank you for the comments.
I'll pick them up in other CLs.

[bashi, 2017-02-13 23:07:51]

lgtm