Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.h.tmpl

Issue 2692753003: [Bindings] Update runtime enabled features from partial interfaces (Closed)
Patch Set: Remove needless classname addition Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/interface.h.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/interface.h.tmpl b/third_party/WebKit/Source/bindings/templates/interface.h.tmpl
index a72b5c2b9b2119c6055555cd6d196b8010f4b03f..699ef7aade48cd488ab7c0d433dca12981a5cdaa 100644
--- a/third_party/WebKit/Source/bindings/templates/interface.h.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/interface.h.tmpl
@@ -136,22 +136,13 @@ class {{v8_class}} {
{{exported}}static void preparePrototypeAndInterfaceObject(v8::Local<v8::Context>, const DOMWrapperWorld&, v8::Local<v8::Object> prototypeObject, v8::Local<v8::Function> interfaceObject, v8::Local<v8::FunctionTemplate> interfaceTemplate) {}
{% endif %}
{% if has_partial_interface %}
- {{exported}}static void updateWrapperTypeInfo(InstallTemplateFunction, PreparePrototypeAndInterfaceObjectFunction);
+ {{exported}}static void updateWrapperTypeInfo(InstallTemplateFunction, InstallRuntimeEnabledFunction, PreparePrototypeAndInterfaceObjectFunction);
{{exported}}static void install{{v8_class}}Template(v8::Isolate*, const DOMWrapperWorld&, v8::Local<v8::FunctionTemplate> interfaceTemplate);
{% for method in methods if method.overloads and method.overloads.has_partial_overloads %}
{{exported}}static void register{{method.name | blink_capitalize}}MethodForPartialInterface(void (*)(const v8::FunctionCallbackInfo<v8::Value>&));
{% endfor %}
{% endif %}
- {% if needs_runtime_enabled_installer %}
- {{exported}}static void installRuntimeEnabledFeatures(
- v8::Isolate* isolate,
- const DOMWrapperWorld& world,
- v8::Local<v8::Object> instance,
- v8::Local<v8::Object> prototype,
- v8::Local<v8::Function> interface);
- {% endif %}
-
{% for feature in origin_trial_features %}
static void install{{feature.name}}(v8::Isolate*, const DOMWrapperWorld&, v8::Local<v8::Object> instance, v8::Local<v8::Object> prototype, v8::Local<v8::Function> interface);
@@ -258,6 +249,19 @@ class {{v8_class}} {
{{exported}}static void indexedPropertyDeleterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Boolean>&);
{% endif %}
+ {% if needs_runtime_enabled_installer %}
+ {{exported}}static void installRuntimeEnabledFeatures(
+ v8::Isolate* isolate,
+ const DOMWrapperWorld& world,
+ v8::Local<v8::Object> instance,
+ v8::Local<v8::Object> prototype,
+ v8::Local<v8::Function> interface);
+
+ {% if has_partial_interface %}
+ static InstallRuntimeEnabledFunction install{{v8_class}}RuntimeEnabledFunction;
+ {% endif %}
+ {% endif %}
+
{% if has_partial_interface %}
private:
static InstallTemplateFunction install{{v8_class}}TemplateFunction;

Powered by Google App Engine
This is Rietveld 408576698