third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc - Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc

Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space. (Closed)

Patch Set: CR fixes, merge w master Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc

index 9ff53814d10f4dfdd533bbe277f382dfec78ebad..d7b15e17f222504a586a8584ee20d685fedcddb7 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc

@@ -66,7 +66,8 @@ class NGInlineNodeTest : public ::testing::Test {

void CreateLine(NGInlineNode* node,

Vector<RefPtr<const NGPhysicalTextFragment>>* fragments_out) {

NGConstraintSpace* constraint_space =

- NGConstraintSpaceBuilder(kHorizontalTopBottom).ToConstraintSpace();

+ NGConstraintSpaceBuilder(kHorizontalTopBottom)

+ .ToConstraintSpace(kHorizontalTopBottom);

NGLineBuilder line_builder(node, constraint_space);

NGTextLayoutAlgorithm algorithm(node, constraint_space);