third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc - Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space. (Closed)

Patch Set: CR fixes, merge w master Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

index 0c36c5418d5dc0f38d5d67e1203c2639edf8763b..6da8e9e31c97faa6a5865e2a17c071cf2e6ba0dd 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

@@ -23,7 +23,7 @@ NGConstraintSpace* ConstructConstraintSpace(NGWritingMode writing_mode,

.SetIsFixedSizeInline(true)

.SetIsInlineDirectionTriggersScrollbar(true)

.SetFragmentationType(NGFragmentationType::kFragmentColumn)

- .ToConstraintSpace();

+ .ToConstraintSpace(writing_mode);

}

static String OpportunityToString(const NGLayoutOpportunity& opportunity) {