third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc - Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc

Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space. (Closed)

Patch Set: CR fixes, merge w master Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc

index e298674e64c5f1ff2b92d872e7e41d1257b2abfb..525d91815e4e45ee5f4fe69ea6fa507e49ede062 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc

@@ -192,7 +192,7 @@ MinAndMaxContentSizes ComputeMinAndMaxContentContribution(

NGConstraintSpaceBuilder builder(writing_mode);

builder.SetInitialContainingBlockSize(

NGPhysicalSize{LayoutUnit(), LayoutUnit()});

- NGConstraintSpace* space = builder.ToConstraintSpace();

+ NGConstraintSpace* space = builder.ToConstraintSpace(writing_mode);

MinAndMaxContentSizes computed_sizes;

Length inline_size = style.logicalWidth();