third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc - Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc

Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space. (Closed)

Patch Set: CR fixes, merge w master Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc

index 38ebd90e52305b9a4a99a071caea63764ddb8784..1c85d75bb52b6e84ac9ac17ff7db956616bda0bd 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc

@@ -33,12 +33,12 @@ TEST(NGConstraintSpaceBuilderTest, AvailableSizeFromHorizontalICB) {

horizontal_builder.SetPercentageResolutionSize(fixed_size);

NGConstraintSpaceBuilder vertical_builder(

- horizontal_builder.ToConstraintSpace());

+ horizontal_builder.ToConstraintSpace(kHorizontalTopBottom));

vertical_builder.SetAvailableSize(indefinite_size);

vertical_builder.SetPercentageResolutionSize(indefinite_size);

- vertical_builder.SetWritingMode(kVerticalLeftRight);

- NGConstraintSpace* space = vertical_builder.ToConstraintSpace();

+ NGConstraintSpace* space =

+ vertical_builder.ToConstraintSpace(kVerticalLeftRight);

EXPECT_EQ(space->AvailableSize().inline_size, icb_size.height);

EXPECT_EQ(space->PercentageResolutionSize().inline_size, icb_size.height);

@@ -57,12 +57,12 @@ TEST(NGConstraintSpaceBuilderTest, AvailableSizeFromVerticalICB) {

horizontal_builder.SetPercentageResolutionSize(fixed_size);

NGConstraintSpaceBuilder vertical_builder(

- horizontal_builder.ToConstraintSpace());

+ horizontal_builder.ToConstraintSpace(kVerticalLeftRight));

vertical_builder.SetAvailableSize(indefinite_size);

vertical_builder.SetPercentageResolutionSize(indefinite_size);

- vertical_builder.SetWritingMode(kHorizontalTopBottom);

- NGConstraintSpace* space = vertical_builder.ToConstraintSpace();

+ NGConstraintSpace* space =

+ vertical_builder.ToConstraintSpace(kHorizontalTopBottom);

EXPECT_EQ(space->AvailableSize().inline_size, icb_size.width);

EXPECT_EQ(space->PercentageResolutionSize().inline_size, icb_size.width);