third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc - Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space. (Closed)

Patch Set: CR fixes, merge w master Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

index 36f5a94e046587f2d7a9cbdd1fcf13824c78957e..1e653fc86dbfbda45a474d086023d56cbe90ea6c 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

@@ -100,7 +100,7 @@ NGConstraintSpace* NGConstraintSpace::CreateFromLayoutObject(

box.sizesLogicalWidthToFitContent(box.styleRef().logicalWidth()))

.SetIsNewFormattingContext(is_new_fc)

.SetTextDirection(box.styleRef().direction())

- .ToConstraintSpace();

+ .ToConstraintSpace(writing_mode);

}

void NGConstraintSpace::AddExclusion(const NGExclusion& exclusion) {