Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space. (Closed)
Patch Set: CR fixes, merge w master Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
index a9918a416eb3994da590ab2fa3cadc021079c178..61549af0b465dfc9239989189ac5753feba64e9b 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
@@ -44,8 +44,6 @@ class CORE_EXPORT NGConstraintSpaceBuilder final
NGConstraintSpaceBuilder& SetFragmentationType(NGFragmentationType);
NGConstraintSpaceBuilder& SetIsNewFormattingContext(bool is_new_fc);
- NGConstraintSpaceBuilder& SetWritingMode(NGWritingMode writing_mode);
-
NGConstraintSpaceBuilder& SetMarginStrut(const NGMarginStrut& margin_strut);
NGConstraintSpaceBuilder& SetBfcOffset(const NGLogicalOffset& offset) {
@@ -59,7 +57,9 @@ class CORE_EXPORT NGConstraintSpaceBuilder final
// - Is within a fragmentation container and needs its fragmentation offset
// updated.
// - Has its size is determined by its parent layout (flex, abs-pos).
- NGConstraintSpace* ToConstraintSpace();
+ //
+ // NGWritingMode specifies the writing mode of the generated space.
+ NGConstraintSpace* ToConstraintSpace(NGWritingMode);
DEFINE_INLINE_TRACE() {}
@@ -71,7 +71,6 @@ class CORE_EXPORT NGConstraintSpaceBuilder final
NGPhysicalSize initial_containing_block_size_;
LayoutUnit fragmentainer_space_available_;
- unsigned writing_mode_ : 2;
unsigned parent_writing_mode_ : 2;
unsigned is_fixed_size_inline_ : 1;
unsigned is_fixed_size_block_ : 1;

Powered by Google App Engine
This is Rietveld 408576698