Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space. (Closed)
Patch Set: CR fixes, merge w master Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
index f95e7fd31ac1655e8a3f8eccaaf4d1fa963924e2..7e8127a48780df6ce49966c3c011861e117d73f2 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
@@ -118,7 +118,7 @@ MinAndMaxContentSizes NGBlockNode::ComputeMinAndMaxContentSizes() {
NGConstraintSpaceBuilder(
FromPlatformWritingMode(Style().getWritingMode()))
.SetTextDirection(Style().direction())
- .ToConstraintSpace();
+ .ToConstraintSpace(FromPlatformWritingMode(Style().getWritingMode()));
// TODO(cbiesinger): For orthogonal children, we need to always synthesize.
NGBlockLayoutAlgorithm minmax_algorithm(layout_box_, &Style(), FirstChild(),
@@ -141,7 +141,7 @@ MinAndMaxContentSizes NGBlockNode::ComputeMinAndMaxContentSizes() {
.SetTextDirection(Style().direction())
.SetAvailableSize({LayoutUnit::max(), LayoutUnit()})
.SetPercentageResolutionSize({LayoutUnit(), LayoutUnit()})
- .ToConstraintSpace();
+ .ToConstraintSpace(FromPlatformWritingMode(Style().getWritingMode()));
physical_fragment = Layout(constraint_space);
NGBoxFragment max_fragment(FromPlatformWritingMode(Style().getWritingMode()),

Powered by Google App Engine
This is Rietveld 408576698