Convert //ios/web_view/internal to ARC.

Convert //ios/web_view/internal to ARC.

BUG=691068
Review-Url: https://codereview.chromium.org/2692603002
Cr-Commit-Position: refs/heads/master@{#449991}
Committed: https://chromium.googlesource.com/chromium/src/+/678c69f827ceeb85bab41d2cf0480940a7689bf3

[michaeldo, 2017-02-10 20:53:16]

michaeldo@chromium.org changed reviewers:
+ eugenebut@chromium.org, stkhapugin@chromium.org

[michaeldo, 2017-02-10 20:53:17]

I went ahead and converted this target since it simpler than fixing the gn deps
issues which arose from adding a static lib for ios/web_view in
https://codereview.chromium.org/2665333002/

eugenebut@ for owners approval
stkhapugin@ for ARC conversion validation

[Eugene But (OOO till 7-30), 2017-02-10 23:07:22]

lgtm as long as Stepan is happy with this CL.

https://codereview.chromium.org/2692603002/diff/1/ios/web_view/internal/criwv.mm
File ios/web_view/internal/criwv.mm (right):

https://codereview.chromium.org/2692603002/diff/1/ios/web_view/internal/criwv...
ios/web_view/internal/criwv.mm:29: __unsafe_unretained id<CRIWVDelegate>
_delegate;
Should this be __weak?

https://codereview.chromium.org/2692603002/diff/1/ios/web_view/internal/criwv...
File ios/web_view/internal/criwv_web_view.mm (right):

https://codereview.chromium.org/2692603002/diff/1/ios/web_view/internal/criwv...
ios/web_view/internal/criwv_web_view.mm:35: __unsafe_unretained
id<CRIWVWebViewDelegate> _delegate;
Do we even need an ivar for this? Should we just have a weak property instead?

[michaeldo, 2017-02-11 06:02:32]

https://codereview.chromium.org/2692603002/diff/1/ios/web_view/internal/criwv.mm
File ios/web_view/internal/criwv.mm (right):

https://codereview.chromium.org/2692603002/diff/1/ios/web_view/internal/criwv...
ios/web_view/internal/criwv.mm:29: __unsafe_unretained id<CRIWVDelegate>
_delegate;
On 2017/02/10 23:07:22, Eugene But wrote:
> Should this be __weak?

I was basing this off the arc migrate instructions, but yes, __weak I believe is
what we want here. Updated.

Stepan, please confirm.

https://codereview.chromium.org/2692603002/diff/1/ios/web_view/internal/criwv...
File ios/web_view/internal/criwv_web_view.mm (right):

https://codereview.chromium.org/2692603002/diff/1/ios/web_view/internal/criwv...
ios/web_view/internal/criwv_web_view.mm:35: __unsafe_unretained
id<CRIWVWebViewDelegate> _delegate;
On 2017/02/10 23:07:22, Eugene But wrote:
> Do we even need an ivar for this? Should we just have a weak property instead?

I agree, a property would be better. Updated.

[stkhapugin, 2017-02-13 15:54:59]

ARC lgtm

https://codereview.chromium.org/2692603002/diff/20001/ios/web_view/internal/c...
File ios/web_view/internal/criwv_web_client.h (right):

https://codereview.chromium.org/2692603002/diff/20001/ios/web_view/internal/c...
ios/web_view/internal/criwv_web_client.h:37: __weak id<CRIWVDelegate> delegate_;
Just a heads-up, this prevents this class from being included from non-ARC code.
Which is fine with me. Same everywhere where you put __weak in .h.

[michaeldo, 2017-02-13 16:04:15]

https://codereview.chromium.org/2692603002/diff/20001/ios/web_view/internal/c...
File ios/web_view/internal/criwv_web_client.h (right):

https://codereview.chromium.org/2692603002/diff/20001/ios/web_view/internal/c...
ios/web_view/internal/criwv_web_client.h:37: __weak id<CRIWVDelegate> delegate_;
On 2017/02/13 15:54:59, stkhapugin wrote:
> Just a heads-up, this prevents this class from being included from non-ARC
code.
> Which is fine with me. Same everywhere where you put __weak in .h.

Thanks for pointing that out. This is definitely ok with me here since this is
only part of the internal headers. (We likely want to impose this restriction in
ios/web_view/public/*.h too, but if not, I can update the public API in the
future.)

[michaeldo, 2017-02-13 16:04:39]

The CQ bit was checked by michaeldo@chromium.org

[michaeldo, 2017-02-13 16:04:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2692603002/#ps20001
(title: "Respond to comments.")

[commit-bot: I haz the power, 2017-02-13 16:05:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 17:36:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487001879617410,
"parent_rev": "bbc4a70794bcc3a2f33291732fbb9c679e9b4418", "commit_rev":
"678c69f827ceeb85bab41d2cf0480940a7689bf3"}

[commit-bot: I haz the power, 2017-02-13 17:37:03]

Description was changed from

==========
Convert //ios/web_view/internal to ARC.

BUG=691068
==========

to

==========
Convert //ios/web_view/internal to ARC.

BUG=691068

Review-Url: https://codereview.chromium.org/2692603002
Cr-Commit-Position: refs/heads/master@{#449991}
Committed:
https://chromium.googlesource.com/chromium/src/+/678c69f827ceeb85bab41d2cf048...
==========

[commit-bot: I haz the power, 2017-02-13 17:37:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/678c69f827ceeb85bab41d2cf048...