Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: ios/web_view/internal/BUILD.gn

Issue 2692603002: Convert //ios/web_view/internal to ARC. (Closed)
Patch Set: Respond to comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web_view/internal/criwv.mm » ('j') | ios/web_view/internal/criwv_web_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/internal/BUILD.gn
diff --git a/ios/web_view/internal/BUILD.gn b/ios/web_view/internal/BUILD.gn
index d5f4c6cb1827fd4d9260cb49ee24b78b776a546b..851617bfde39f2bbb04fba89c9eefdbf1f67ce22 100644
--- a/ios/web_view/internal/BUILD.gn
+++ b/ios/web_view/internal/BUILD.gn
@@ -2,26 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-source_set("internal_arc") {
- visibility = [
- "//ios/web_view",
- "//ios/web_view/internal/*",
- ]
-
- sources = [
- "criwv_web_view_configuration.mm",
- "criwv_website_data_store.mm",
- "criwv_website_data_store_internal.h",
- ]
-
- deps = [
- "//ios/web/public/app",
- "//ios/web_view/public",
- ]
-
- configs += [ "//build/config/compiler:enable_arc" ]
-}
-
source_set("internal") {
visibility = [
"//ios/web_view",
@@ -43,6 +23,9 @@ source_set("internal") {
"criwv_web_main_parts.h",
"criwv_web_main_parts.mm",
"criwv_web_view.mm",
+ "criwv_web_view_configuration.mm",
+ "criwv_website_data_store.mm",
+ "criwv_website_data_store_internal.h",
"pref_names.cc",
"pref_names.h",
]
@@ -64,12 +47,7 @@ source_set("internal") {
"//url",
]
- public_deps = [
- ":internal_arc",
- ]
+ allow_circular_includes_from = [ "//ios/web_view/internal/translate" ]
- allow_circular_includes_from = [
- ":internal_arc",
- "//ios/web_view/internal/translate",
- ]
+ configs += [ "//build/config/compiler:enable_arc" ]
}
« no previous file with comments | « no previous file | ios/web_view/internal/criwv.mm » ('j') | ios/web_view/internal/criwv_web_client.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698