Auto-generate null checks for pointer arguemnts in the passthrough cmd decoder.

Auto-generate null checks for pointer arguemnts in the passthrough cmd decoder.

Argument validation wasn't added previously because it was mostly for
enum checks.  These null checks prevent issues where the buffer is not
big enough and null was returned when getting immediate data.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2692573002
Cr-Commit-Position: refs/heads/master@{#449979}
Committed: https://chromium.googlesource.com/chromium/src/+/7b0ca8add9594566989b917f50fb948556125698

[Geoff Lang, 2017-02-10 20:34:21]

Description was changed from

==========
Auto-generate null checks for pointer arguemnts in the passthrough cmd decoder.

Argument validation wasn't added previously because it was mostly for
enum checks.  These null checks prevent issues where the buffer is not
big enough and null was returned when getting immediate data.

BUG=602737
==========

to

==========
Auto-generate null checks for pointer arguemnts in the passthrough cmd decoder.

Argument validation wasn't added previously because it was mostly for
enum checks.  These null checks prevent issues where the buffer is not
big enough and null was returned when getting immediate data.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-02-10 20:44:11]

Description was changed from

==========
Auto-generate null checks for pointer arguemnts in the passthrough cmd decoder.

Argument validation wasn't added previously because it was mostly for
enum checks.  These null checks prevent issues where the buffer is not
big enough and null was returned when getting immediate data.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Auto-generate null checks for pointer arguemnts in the passthrough cmd decoder.

Argument validation wasn't added previously because it was mostly for
enum checks.  These null checks prevent issues where the buffer is not
big enough and null was returned when getting immediate data.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-02-10 20:44:12]

geofflang@chromium.org changed reviewers:
+ zmo@chromium.org

[Geoff Lang, 2017-02-10 20:44:16]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[Geoff Lang, 2017-02-10 20:44:25]

PTAL

[commit-bot: I haz the power, 2017-02-10 20:45:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2017-02-10 21:01:23]

lgtm with a nit

https://codereview.chromium.org/2692573002/diff/1/gpu/command_buffer/build_gl...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/2692573002/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:8887: f.write("  if (%s == NULL)
{\n" % self.name)
Can we use nullptr instead?

[commit-bot: I haz the power, 2017-02-10 22:19:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 22:19:37]

Dry run: This issue passed the CQ dry run.

[Geoff Lang, 2017-02-13 15:52:24]

https://codereview.chromium.org/2692573002/diff/1/gpu/command_buffer/build_gl...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/2692573002/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:8887: f.write("  if (%s == NULL)
{\n" % self.name)
On 2017/02/10 21:01:23, Zhenyao Mo wrote:
> Can we use nullptr instead?

Done.

[Geoff Lang, 2017-02-13 15:52:28]

The CQ bit was checked by geofflang@chromium.org

[Geoff Lang, 2017-02-13 15:52:28]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2692573002/#ps20001
(title: "use nullptr instead of NULL")

[commit-bot: I haz the power, 2017-02-13 15:52:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 16:48:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487001148599690,
"parent_rev": "3367918b26e434d16f477c75443389e6ec2873aa", "commit_rev":
"7b0ca8add9594566989b917f50fb948556125698"}

[commit-bot: I haz the power, 2017-02-13 16:49:21]

Description was changed from

==========
Auto-generate null checks for pointer arguemnts in the passthrough cmd decoder.

Argument validation wasn't added previously because it was mostly for
enum checks.  These null checks prevent issues where the buffer is not
big enough and null was returned when getting immediate data.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Auto-generate null checks for pointer arguemnts in the passthrough cmd decoder.

Argument validation wasn't added previously because it was mostly for
enum checks.  These null checks prevent issues where the buffer is not
big enough and null was returned when getting immediate data.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2692573002
Cr-Commit-Position: refs/heads/master@{#449979}
Committed:
https://chromium.googlesource.com/chromium/src/+/7b0ca8add9594566989b917f50fb...
==========

[commit-bot: I haz the power, 2017-02-13 16:49:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7b0ca8add9594566989b917f50fb...