Auto-generate null checks for pointer arguemnts in the passthrough cmd decoder.

gpu/command_buffer/build_gles2_cmd_buffer.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """code generator for GLES2 command buffers."""
 
 import itertools
 import os
 import os.path
@@ skipping 4978 matching lines @@
     f.write("""  error::Error error = Do%(name)s(%(args)s);
   if (error != error::kNoError) {
     return error;
   }""" % {'name': func.original_name,
           'args': func.MakePassthroughServiceDoerArgString("")})
 
   def WritePassthroughServiceImplementation(self, func, f):
     """Writes the service implementation for a command."""
     self.WritePassthroughServiceFunctionHeader(func, f)
     self.WriteServiceHandlerArgGetCode(func, f)
+    func.WritePassthroughHandlerValidation(f)
     self.WritePassthroughServiceFunctionDoerCall(func, f)
     f.write("  return error::kNoError;\n")
     f.write("}\n")
     f.write("\n")
 
   def WritePassthroughImmediateServiceImplementation(self, func, f):
     """Writes the service implementation for a command."""
     self.WritePassthroughServiceFunctionHeader(func, f)
     self.WriteImmediateServiceHandlerArgGetCode(func, f)
+    func.WritePassthroughHandlerValidation(f)
     self.WritePassthroughServiceFunctionDoerCall(func, f)
     f.write("  return error::kNoError;\n")
     f.write("}\n")
     f.write("\n")
 
   def WritePassthroughBucketServiceImplementation(self, func, f):
     """Writes the service implementation for a command."""
     self.WritePassthroughServiceFunctionHeader(func, f)
     self.WriteBucketServiceHandlerArgGetCode(func, f)
+    func.WritePassthroughHandlerValidation(f)
     self.WritePassthroughServiceFunctionDoerCall(func, f)
     f.write("  return error::kNoError;\n")
     f.write("}\n")
     f.write("\n")
 
   def WriteHandlerExtensionCheck(self, func, f):
     if func.GetInfo('extension_flag'):
       f.write("  if (!features().%s) {\n" % func.GetInfo('extension_flag'))
       f.write("    return error::kUnknownCommand;")
       f.write("  }\n\n")
@@ skipping 3552 matching lines @@
     f.write("%s%s = %s;\n" % (' ' * indent, self.name, var))
 
   def WriteArgAccessor(self, f):
     """Writes specialized accessor for argument."""
     pass
 
   def WriteValidationCode(self, f, func):
     """Writes the validation code for an argument."""
     pass
 
+  def WritePassthroughValidationCode(self, f, func):
+    """Writes the passthrough validation code for an argument."""
+    pass
+
   def WriteClientSideValidationCode(self, f, func):
     """Writes the validation code for an argument."""
     pass
 
   def WriteDestinationInitalizationValidation(self, f, func):
     """Writes the client side destintion initialization validation."""
     pass
 
   def WriteDestinationInitalizationValidatationIfNeeded(self, f, func):
     """Writes the client side destintion initialization validation if needed."""
@@ skipping 267 matching lines @@
     f.write("      c, data_size, immediate_data_size);\n")
 
   def WriteValidationCode(self, f, func):
     """Overridden from Argument."""
     if self.optional:
       return
     f.write("  if (%s == NULL) {\n" % self.name)
     f.write("    return error::kOutOfBounds;\n")
     f.write("  }\n")
 
+  def WritePassthroughValidationCode(self, f, func):
+    """Overridden from Argument."""
+    if self.optional:
+      return
+    f.write("  if (%s == nullptr) {\n" % self.name)
+    f.write("    return error::kOutOfBounds;\n")
+    f.write("  }\n")
+
   def GetImmediateVersion(self):
     """Overridden from Argument."""
     return None
 
   def WriteDestinationInitalizationValidation(self, f, func):
     """Overridden from Argument."""
     self.WriteDestinationInitalizationValidatationIfNeeded(f, func)
 
   def GetLogArg(self):
     """Overridden from Argument."""
@@ skipping 609 matching lines @@
     """Makes a string of the arguments for the LOG macros"""
     args = self.GetOriginalArgs()
     return ' << ", " << '.join([arg.GetLogArg() for arg in args])
 
   def WriteHandlerValidation(self, f):
     """Writes validation code for the function."""
     for arg in self.GetOriginalArgs():
       arg.WriteValidationCode(f, self)
     self.WriteValidationCode(f)
 
+  def WritePassthroughHandlerValidation(self, f):
+    """Writes validation code for the function."""
+    for arg in self.GetOriginalArgs():
+      arg.WritePassthroughValidationCode(f, self)
+
   def WriteHandlerImplementation(self, f):
     """Writes the handler implementation for this command."""
     self.type_handler.WriteHandlerImplementation(self, f)
 
   def WriteValidationCode(self, f):
     """Writes the validation code for a command."""
     pass
 
   def WriteCmdFlag(self, f):
     """Writes the cmd cmd_flags constant."""
@@ skipping 1688 matching lines @@
   Format(gen.generated_cpp_filenames)
 
   if gen.errors > 0:
     print "%d errors" % gen.errors
     return 1
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))