Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2692503002: [Payments] Request focus and hide keyboard when clicking dropdown field (Closed)

Created:
3 years, 10 months ago by gogerald1
Modified:
3 years, 10 months ago
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Request focus and hide keyboard when clicking dropdown field BUG=690958 Review-Url: https://codereview.chromium.org/2692503002 Cr-Commit-Position: refs/heads/master@{#449656} Committed: https://chromium.googlesource.com/chromium/src/+/4351ecce4a1e348d5de6075372f45093110cd62c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
gogerald1
Hi rouslan@ and tedchoc@, PTAL, please check the result posted on the bug,
3 years, 10 months ago (2017-02-10 16:50:26 UTC) #5
please use gerrit instead
LGTM based on the behavior in the video
3 years, 10 months ago (2017-02-10 17:07:52 UTC) #6
Ted C
lgtm
3 years, 10 months ago (2017-02-10 17:28:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692503002/1
3 years, 10 months ago (2017-02-10 17:56:53 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 18:04:56 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4351ecce4a1e348d5de6075372f4...

Powered by Google App Engine
This is Rietveld 408576698