Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3805)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java

Issue 2692503002: [Payments] Request focus and hide keyboard when clicking dropdown field (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
index ed7d2593518ff4b9203443610da01936ef84e992..ea457b1905c2e8a6065fc5987c95168025b8bc78 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
@@ -4,8 +4,10 @@
package org.chromium.chrome.browser.payments.ui;
+import android.annotation.SuppressLint;
import android.content.Context;
import android.view.LayoutInflater;
+import android.view.MotionEvent;
import android.view.View;
import android.view.ViewGroup;
import android.view.accessibility.AccessibilityEvent;
@@ -100,6 +102,14 @@ class EditorDropdownField implements EditorFieldView {
@Override
public void onNothingSelected(AdapterView<?> parent) {}
});
+ mDropdown.setOnTouchListener(new View.OnTouchListener() {
+ @SuppressLint("ClickableViewAccessibility")
+ @Override
+ public boolean onTouch(View v, MotionEvent event) {
+ if (event.getAction() == MotionEvent.ACTION_DOWN) requestFocusAndHideKeyboard();
+ return false;
+ }
+ });
}
/** @return The View containing everything. */
@@ -138,6 +148,10 @@ class EditorDropdownField implements EditorFieldView {
@Override
public void scrollToAndFocus() {
updateDisplayedError(!isValid());
+ requestFocusAndHideKeyboard();
+ }
+
+ private void requestFocusAndHideKeyboard() {
UiUtils.hideKeyboard(mDropdown);
ViewGroup parent = (ViewGroup) mDropdown.getParent();
if (parent != null) parent.requestChildFocus(mDropdown, mDropdown);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698